| Summary: | ASTERISK-23836: JACK_HOOK with more than 8Khz | ||||
| Reporter: | Dennis Guse (dennis.guse) | Labels: | |||
| Date Opened: | 2014-06-09 14:27:25 | Date Closed: | 2014-06-26 07:47:40 | ||
| Priority: | Minor | Regression? | No | ||
| Status: | Closed/Complete | Components: | Applications/app_jack | ||
| Versions: | SVN | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Ubuntu 14.04 using 11.7 and trunk in combination with jackd and puredata. | Attachments: | ( 0) patch-app_jack.c | ||
| Description: | So far app_jack is limited to 8Khz only.
The following patch adds support for dynamic sampling rates using information provided by the channel. Checked with Linphone and Ekiga using G.711 and G.722 on Ubuntu 14.04 64bit. Limitations: * Information, i.e. sampling rate, is taken from channel during initialization as audiohook does not provide this information then. Audiohook.internal_sampl_rate is set later, but no callback is called. * Frame.datalen is computed using rate / 50 assuming a ptime of 20ms. There is no internal API available to determine datalen for a SLINxx. * Ringbuffer size is a DEFINE and thus must be quite big to be able to cope with 16Khz+ PS: This bug report is a duplicate of ASTERISK-20696 | ||||
| Comments: | By: Matt Jordan (mjordan) 2014-06-12 06:47:11.960-0500 From a cursory glance, the patch could use some clean up before going up for peer review. Please review the [Coding Guidelines|https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines] before posting it for review. Some obvious things: # Don't use your name in comments # Don't leave commented out code # Don't use {{//}} for comments # Leaving {{0 != 0}} in a conditional is ... not useful? :-) Once the patch conforms to the coding guidelines, please post it for peer review on review board. You can find instructions on doing so here: https://wiki.asterisk.org/wiki/display/AST/Code+Review | ||||