Summary:	ASTERISK-23895: res_pjsip_t38: T.38 Framehook prevents local native bridge
Reporter:	Matt Jordan (mjordan)	Labels:
Date Opened:	2014-06-15 21:31:19	Date Closed:	2017-12-18 09:54:53.000-0600
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Bridges/bridge_native_rtp Resources/res_pjsip_t38
Versions:	12.3.0	Frequency of Occurrence
Related Issues:	is related to ASTERISK-25582 Testsuite: Reactor timeout error in tests/fax/pjsip/directmedia_reinvite_t38
Environment:		Attachments:
Description:	While investigating why the SIP native T.38 test was failing post https://reviewboard.asterisk.org/r/3585, I discovered that the PJSIP native T.38 test wasn't really ... native. Due to using a framehook to read/write T.38 data, the {{pjsip}} channel driver will never allow {{bridge_native_rtp}} to be used. A few things need to be cleaned up: # We probably shouldn't rely on a framehook to do all reading/writing. Image is a valid media stream and should be stored in {{chan_pjsip_pvt-media}} - and read/written from {{chan_pjsip}} # {{chan_pjsip_get_rtp_peer}} should be updated to check the state of T.38 negotiation. If T.38 has been negotiated successfully, we need to forbid remote bridging (which was the bug in the {{chan_sip}} code). This is particularly needed as the gateway framehook will soft hangup a channel, causing a bridge reconfigure (and this function) to be called
Comments: