| Summary: | ASTERISK-23908: [patch]When using FEC error correction, asterisk tries considers negative sequence numbers as missing | ||
| Reporter: | Torrey Searle (tsearle) | Labels: | |
| Date Opened: | 2014-06-18 10:52:57 | Date Closed: | 2014-06-26 07:46:10 |
| Priority: | Major | Regression? | |
| Status: | Closed/Complete | Components: | Core/UDPTL |
| Versions: | 11.10.1 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) t38_fec_issue.pcap ( 1) udptl_fec.patch | |
| Description: | When using FEC error correction with span=3 and entries=4 asterisk will try to repair in packet with sequence number 5 because it will see that packet -4 is missing. The result is that Asterisk will forward garbage packets that can possibly kill the fax.
Attatched is an example pcap showing this issue and a patch to resolve this issue | ||
| Comments: | By: Torrey Searle (tsearle) 2014-06-18 10:54:30.600-0500 Example callflow with the FEC issue By: Rusty Newton (rnewton) 2014-06-19 17:05:55.677-0500 Thanks Torrey, you can go ahead and throw the patch on reviewboard as well. Remember to link the JIRA issue to the reviewboard URL. By: Matt Jordan (mjordan) 2014-06-19 17:12:47.154-0500 Very quick comment on the patch: # Put spaces between {{if}} and {{(}}. # Use { and } even for single line conditionals. I haven't looked at the udptl code in a long time, so I can't comment yet on the patch itself... but that's what review board is for :-) | ||