| Summary: | ASTERISK-23916: [patch]SIP/SDP fmtp line may include whitespace between attributes | ||
| Reporter: | Alexander Traud (traud) | Labels: | |
| Date Opened: | 2014-06-20 09:44:55 | Date Closed: | 2014-06-29 22:25:29 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Channels/chan_sip/CodecHandling |
| Versions: | 11.10.2 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) sdpFMTPspace_Asterisk11.patch | |
| Description: | See SVN revision 397526, [review 2723|https://reviewboard.asterisk.org/r/2723/] and ASTERISK-21981: "For the audio codec Opus, its RFC specifies having spaces delimiting the attributes in addition to ';', so you have "attra=X; attrb=Y". This broke the attribute parsing in chan_sip, so a small tweak was also included in this patch for that."
I created a pass-through module for AMR and AMR-WB which works with Asterisk 11 and Asterisk 12. [RFC 4867|http://tools.ietf.org/html/rfc4867#section-8.3.3] (originally from 2001) and AMR implementations (Nokia Mobile Phones) include spaces between attributes like Opus. The current code forwards only one attribute and ignores all other attributes which is not sufficient for all AMR use-cases. Please, consider to backport this tweak into Asterisk 11 LTS. | ||
| Comments: | |||