Asterisk
  1. Asterisk
  2. ASTERISK-23951

Asterisk attempts and fails to build format_mp3 even if mp3lib was not downloaded

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 11.10.2
    • Target Release Version/s: 13.17.0, 14.6.0, 15.0.0
    • Component/s: Addons/format_mp3
    • Security Level: None
    • Labels:
      None

      Description

      I'm working on a a package of Asterisk. It originally had:

      menuselect/menuselect --enable-category MENUSELECT_ADDONS

      contrib/scripts/get_mp3_source.sh

      I wanted to avoid the latter as I don't want to download at build time and thus removed it. The result is:

      [CC] format_mp3.c -> format_mp3.o
      format_mp3.c:39:24: error: mp3/mpg123.h: No such file or directory
      format_mp3.c:40:24: error: mp3/mpglib.h: No such file or directory
      format_mp3.c:52: error: field 'mp' has incomplete type
      format_mp3.c: In function 'mp3_open':
      format_mp3.c:102: warning: implicit declaration of function 'InitMP3'
      format_mp3.c: In function 'mp3_close':
      format_mp3.c:111: warning: implicit declaration of function 'ExitMP3'
      format_mp3.c: In function 'mp3_squeue':
      format_mp3.c:126: warning: implicit declaration of function 'decodeMP3'
      format_mp3.c:127: error: 'MP3_OK' undeclared (first use in this function)
      format_mp3.c:127: error: (Each undeclared identifier is reported only once
      format_mp3.c:127: error: for each function it appears in.)
      format_mp3.c: In function 'mp3_dqueue':
      format_mp3.c:139: error: 'MP3_OK' undeclared (first use in this function)
      format_mp3.c: In function 'mp3_queue':
      format_mp3.c:159: error: 'MP3_OK' undeclared (first use in this function)
      format_mp3.c:167: error: 'MP3_ERR' undeclared (first use in this function)
      format_mp3.c: In function 'load_module':
      format_mp3.c:322: warning: implicit declaration of function 'InitMP3Constants'
      make[1]: *** [format_mp3.o] Error 1
      make: *** [addons] Error 2

      The lack of mp3 library should be detected and the build should not be attempted, IMHO.

        Issue Links

          Activity

          Hide
          Friendly Automation added a comment -

          Change 5717 merged by Joshua Colp:
          format_mp3: Don't try to build format_mp3 if we don't have sources

          https://gerrit.asterisk.org/5717

          Show
          Friendly Automation added a comment - Change 5717 merged by Joshua Colp: format_mp3: Don't try to build format_mp3 if we don't have sources https://gerrit.asterisk.org/5717
          Hide
          Friendly Automation added a comment -

          Change 5719 merged by Jenkins2:
          format_mp3: Don't try to build format_mp3 if we don't have sources

          https://gerrit.asterisk.org/5719

          Show
          Friendly Automation added a comment - Change 5719 merged by Jenkins2: format_mp3: Don't try to build format_mp3 if we don't have sources https://gerrit.asterisk.org/5719
          Hide
          Friendly Automation added a comment -

          Change 5718 merged by Joshua Colp:
          format_mp3: Don't try to build format_mp3 if we don't have sources

          https://gerrit.asterisk.org/5718

          Show
          Friendly Automation added a comment - Change 5718 merged by Joshua Colp: format_mp3: Don't try to build format_mp3 if we don't have sources https://gerrit.asterisk.org/5718
          Hide
          Friendly Automation added a comment -

          Change 5736 merged by Jenkins2:
          format_mp3: Re-work menuselect/build issues

          https://gerrit.asterisk.org/5736

          Show
          Friendly Automation added a comment - Change 5736 merged by Jenkins2: format_mp3: Re-work menuselect/build issues https://gerrit.asterisk.org/5736
          Hide
          Friendly Automation added a comment -

          Change 5737 merged by Jenkins2:
          format_mp3: Re-work menuselect/build issues

          https://gerrit.asterisk.org/5737

          Show
          Friendly Automation added a comment - Change 5737 merged by Jenkins2: format_mp3: Re-work menuselect/build issues https://gerrit.asterisk.org/5737
          Hide
          Friendly Automation added a comment -

          Change 5738 merged by Joshua Colp:
          format_mp3: Re-work menuselect/build issues

          https://gerrit.asterisk.org/5738

          Show
          Friendly Automation added a comment - Change 5738 merged by Joshua Colp: format_mp3: Re-work menuselect/build issues https://gerrit.asterisk.org/5738

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development