Summary: | ASTERISK-23951: Asterisk attempts and fails to build format_mp3 even if mp3lib was not downloaded | ||
Reporter: | Tzafrir Cohen (tzafrir) | Labels: | |
Date Opened: | 2014-06-26 09:08:43 | Date Closed: | 2017-05-30 05:55:07 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | Addons/format_mp3 |
Versions: | 11.10.2 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ||
Description: | I'm working on a a package of Asterisk. It originally had:
menuselect/menuselect --enable-category MENUSELECT_ADDONS contrib/scripts/get_mp3_source.sh I wanted to avoid the latter as I don't want to download at build time and thus removed it. The result is: [CC] format_mp3.c -> format_mp3.o format_mp3.c:39:24: error: mp3/mpg123.h: No such file or directory format_mp3.c:40:24: error: mp3/mpglib.h: No such file or directory format_mp3.c:52: error: field 'mp' has incomplete type format_mp3.c: In function 'mp3_open': format_mp3.c:102: warning: implicit declaration of function 'InitMP3' format_mp3.c: In function 'mp3_close': format_mp3.c:111: warning: implicit declaration of function 'ExitMP3' format_mp3.c: In function 'mp3_squeue': format_mp3.c:126: warning: implicit declaration of function 'decodeMP3' format_mp3.c:127: error: 'MP3_OK' undeclared (first use in this function) format_mp3.c:127: error: (Each undeclared identifier is reported only once format_mp3.c:127: error: for each function it appears in.) format_mp3.c: In function 'mp3_dqueue': format_mp3.c:139: error: 'MP3_OK' undeclared (first use in this function) format_mp3.c: In function 'mp3_queue': format_mp3.c:159: error: 'MP3_OK' undeclared (first use in this function) format_mp3.c:167: error: 'MP3_ERR' undeclared (first use in this function) format_mp3.c: In function 'load_module': format_mp3.c:322: warning: implicit declaration of function 'InitMP3Constants' make[1]: *** [format_mp3.o] Error 1 make: *** [addons] Error 2 The lack of mp3 library should be detected and the build should not be attempted, IMHO. | ||
Comments: | By: Friendly Automation (friendly-automation) 2017-05-30 05:55:08.832-0500 Change 5717 merged by Joshua Colp: format_mp3: Don't try to build format_mp3 if we don't have sources [https://gerrit.asterisk.org/5717|https://gerrit.asterisk.org/5717] By: Friendly Automation (friendly-automation) 2017-05-30 06:04:58.216-0500 Change 5719 merged by Jenkins2: format_mp3: Don't try to build format_mp3 if we don't have sources [https://gerrit.asterisk.org/5719|https://gerrit.asterisk.org/5719] By: Friendly Automation (friendly-automation) 2017-05-30 06:07:33.694-0500 Change 5718 merged by Joshua Colp: format_mp3: Don't try to build format_mp3 if we don't have sources [https://gerrit.asterisk.org/5718|https://gerrit.asterisk.org/5718] By: Friendly Automation (friendly-automation) 2017-06-01 10:17:53.594-0500 Change 5736 merged by Jenkins2: format_mp3: Re-work menuselect/build issues [https://gerrit.asterisk.org/5736|https://gerrit.asterisk.org/5736] By: Friendly Automation (friendly-automation) 2017-06-01 10:26:28.521-0500 Change 5737 merged by Jenkins2: format_mp3: Re-work menuselect/build issues [https://gerrit.asterisk.org/5737|https://gerrit.asterisk.org/5737] By: Friendly Automation (friendly-automation) 2017-06-01 10:42:23.520-0500 Change 5738 merged by Joshua Colp: format_mp3: Re-work menuselect/build issues [https://gerrit.asterisk.org/5738|https://gerrit.asterisk.org/5738] |