Asterisk
  1. Asterisk
  2. ASTERISK-23989

[patch]SDP offer/answer fails if crypto keys added to non-crypto offer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.28.2
    • Target Release Version/s: 11.24.0, 15.0.0
    • Component/s: Channels/chan_sip/SRTP
    • Security Level: None
    • Labels:
      None
    • Environment:
      Planet earth
    • Frequency of Occurrence:
      Constant
    • Reference Notes:
      Jon Postel. Be gentle in what you receive and strict in what you send.

      Description

      1) We got a new SNOM phone configured so it offered RTP/AVP but for some reason added a=crypto SDES keys.
      2) Microsoft Lync offers RTP/AVP and optional RTP/SAVP in the same SDP, also adding keys if RTP/SAVP is accepted

      Asterisk fails offer answer with the message:
      "We are requesting SRTP for audio, but they responded without it!"
      and sends 488. This error message is wrong and failing is wrong.

      We should ignore non-relevant attributes. If RTP/AVP is the offer, just don't check for the crypto keys and activate p->srtp.

        Issue Links

          Activity

          Hide
          Olle Johansson added a comment -

          I guess this patch will work. Will test during today's work.

          Show
          Olle Johansson added a comment - I guess this patch will work. Will test during today's work.
          Hide
          Rusty Newton added a comment - - edited

          Feel free to throw it on reviewboard for some others to test/review.

          Show
          Rusty Newton added a comment - - edited Feel free to throw it on reviewboard for some others to test/review.
          Hide
          Rusty Newton added a comment -

          Olle Johansson I found ASTERISK-22675 and ASTERISK-20234 which may be the same or related issues. Can you verify?

          Show
          Rusty Newton added a comment - Olle Johansson I found ASTERISK-22675 and ASTERISK-20234 which may be the same or related issues. Can you verify?
          Hide
          Walter Doekes added a comment -

          Git reviews:

          https://gerrit.asterisk.org/#/c/3234/ <-- by Alexander Traud, does the inverse and accepts the SRTP
          https://gerrit.asterisk.org/#/c/3828/ <-- by me, a more complete version of sdes-rtp-avp.diff

          Show
          Walter Doekes added a comment - Git reviews: https://gerrit.asterisk.org/#/c/3234/ <-- by Alexander Traud, does the inverse and accepts the SRTP https://gerrit.asterisk.org/#/c/3828/ <-- by me, a more complete version of sdes-rtp-avp.diff

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development