| Summary: | ASTERISK-23997: chan_sip: port incorrectly incremented for RTCP ICE candidates in SDP answer | ||||
| Reporter: | Badalian Vyacheslav (slavon) | Labels: | |||
| Date Opened: | 2014-07-07 09:05:48 | Date Closed: | 2014-08-24 12:22:58 | ||
| Priority: | Critical | Regression? | No | ||
| Status: | Closed/Complete | Components: | Channels/chan_sip/WebSocket | ||
| Versions: | 11.10.0 11.11.0 | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) plus1.diff | |||
| Description: | sipml5 does not work trougth NAT becouse it's can connect to second candidate port if ice is on. You have small logic bug.
1. You have 2 candidates - port X and port Y. 2. Y = X+1. 3. Also you have ICE in reply to client: X and Y + 1. Y already +1! Result: In ICE answer you have X and X+2. Its wrong. Port before NAT and after NAT must be some! before patch: {code} a=candidate:Had86137 1 UDP 2130706431 10.216.97.55 54982 typ host a=candidate:S5bc2e2f0 1 UDP 1694498815 91.194.226.240 54982 typ srflx a=candidate:Had86137 2 UDP 2130706430 10.216.97.55 54983 typ host a=candidate:S5bc2e2f0 2 UDP 1694498814 91.194.226.240 54984 typ srflx {code} After: {code} a=candidate:Had86137 1 UDP 2130706431 10.216.97.55 54982 typ host a=candidate:S5bc2e2f0 1 UDP 1694498815 91.194.226.240 54982 typ srflx a=candidate:Had86137 2 UDP 2130706430 10.216.97.55 54983 typ host a=candidate:S5bc2e2f0 2 UDP 1694498814 91.194.226.240 54983 typ srflx {code} Patch: \[EDIT\]: mjordan We cannot accept patches inline. Please attach the patch in unified diff format after signing a license agreement. | ||||
| Comments: | By: Matt Jordan (mjordan) 2014-07-07 09:34:10.822-0500 We cannot accept patches inline. Please attach the patch in unified diff format after signing a license agreement. By: Badalian Vyacheslav (slavon) 2014-07-08 08:01:39.329-0500 Added diff By: Badalian Vyacheslav (slavon) 2014-07-16 03:31:01.172-0500 11.11 also affected. without patch WS does now work with NAT By: Badalian Vyacheslav (slavon) 2014-08-09 05:28:39.829-0500 any update to issue? | ||||