[Home]

Summary:ASTERISK-24000: chan_pjsip: Add accountcode setting
Reporter:Matt Jordan (mjordan)Labels:
Date Opened:2014-07-07 21:27:52Date Closed:2014-07-16 09:00:21
Priority:MajorRegression?
Status:Closed/CompleteComponents:Channels/chan_pjsip Resources/res_pjsip
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Most channel drivers allow a user to configure a default accountcode to be associated with channels that are created for an endpoint/peer/what-have-you. {{chan_pjsip}}/{{res_pjsip}} does not.

We probably should allow for that - it makes it a bit easier than setting it up in the dialplan.
Comments:By: Matt Jordan (mjordan) 2014-07-07 21:32:37.205-0500

Tests on https://reviewboard.asterisk.org/r/3725/

By: Jan Svoboda (jan.svoboda) 2014-07-20 06:01:10.629-0500

Hi,

I just came across the same problem, not being able to set the accountcode on PJSIP channels and found this issue.

I noticed that the DB migration file 1d50859ed02e_create_accountcode.py specifies the accountcode column to be a string with the max length of 20.

While the max length of accountcode is currently defined by AST_MAX_ACCOUNT_CODE and being se to 20 in channel.h, I think this limit should be increased to allow the use of UUIDs as account codes.

By: Matt Jordan (mjordan) 2014-07-20 17:56:21.267-0500

Extending the length of the accountcode field would have repercussions across all of Asterisk, including other channel drivers, realtime DB schemas, and CDR schemas.

It's fine to suggest that, but we're past feature freeze for Asterisk 13 - and this is a completely separate improvement from adding an accountcode to chan_pjsip.

If you'd like to propose such an improvement, open a new issue, attach the patch that updates the various channel drivers/schemas, and it could be considered for Asterisk 14.