Summary:	ASTERISK-24045: [patch]Voicemail to email at multiple email addresses
Reporter:	Jacob Barber (Jacoby6000)	Labels:
Date Opened:	2014-07-15 17:31:52	Date Closed:	2014-08-08 15:25:19
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail/NewFeature
Versions:	SVN 12.4.0	Frequency of Occurrence
Related Issues:	causes ASTERISK-24250 [patch] Voicemail with multi-recipients To: header fix
Environment:	CentOS 6	Attachments:	( 0) vm-multi-email.diff ( 1) voicemail-420577-to-comma-fix.diff ( 2) voicemail-to-multiple-emails.diff
Description:	Currently voicemail to email only works with a single email.  This patch allows a user to use a space separated list of emails (up to 512 characters long), where the user would like for the emails to be sent.  This is useful for people who don't want to go through setting up mailing groups, or for people who host provide VoIP services with asterisk as a backend, where their customers don't know how to set up mailing groups.
Comments:	By: Jacob Barber (Jacoby6000) 2014-07-16 13:10:45.089-0500 Updated .diff patch to follow coding standards (converted spaces to tabs.) By: Rusty Newton (rnewton) 2014-07-19 13:59:40.624-0500 Make sure it patches and tests fine against trunk as there is where new features will get put in. Follow the [Code Review process|https://wiki.asterisk.org/wiki/display/AST/Code+Review] and post the patch on Reviewboard for others to review. Edit this issue and fill in the Reviewboard URL field once you have a link to the review on Reviewboard. Thanks! By: Jason Parker (jparker) 2014-07-21 08:48:14.051-0500 This is a patch that we've used for some time in FreePBX (written by me).  It handles things much more sanely and allows for an unlimited amount of addresses. By: Jason Parker (jparker) 2014-07-21 16:59:17.411-0500 I counter reviewboard link with https://reviewboard.asterisk.org/r/3833/. By: abelbeck (abelbeck) 2014-08-09 15:53:23.064-0500 Fix to add the proper number of comma's in multiple To: 's By: abelbeck (abelbeck) 2014-08-09 16:01:59.508-0500 Enclosed "voicemail-420577-to-comma-fix.diff" is a one line change to define the proper number of comma's in the To: header. Originally it looked ahead for a '|' which is off-by-one, but instead use the emailsbuf from strsep() will return NULL when no more comma's are needed. As an aside, while adding the ENDL string after each To: entry seems to work, even with "msmtp", RFC5322 seems to imply this should all be on one line... -- http://tools.ietf.org/html/rfc5322 to              =   "To:" address-list CRLF address-list    =   (address *("," address)) / obs-addr-list -- But, it seems to work as is.