[Home]

Summary:ASTERISK-24198: Typo's
Reporter:Walter Doekes (wdoekes)Labels:fax
Date Opened:2014-08-11 05:15:07Date Closed:2017-12-21 08:35:36.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Documentation
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I wouldn't want to clutter the commit log with 1-letter fixes.

So, thought I'd use this ticket to collect a few more typo's before committing.

P.S. The below isn't something anyone could claim copyright over, so I figured the no-inline-patches rule doesn't need to apply. (Plus, if I commit it myself, it should be fine too.)
Comments:By: Matt Jordan (mjordan) 2014-08-11 08:21:36.053-0500

I don't think we need a bunch of code reviews for typo fixes either :-)

If you find one, feel free to fix it and merge it on up.

By: Walter Doekes (wdoekes) 2014-12-17 03:55:36.637-0600

Fixed while committing ASTERISK-24619

By: Walter Doekes (wdoekes) 2015-01-23 09:06:08.095-0600

{noformat}
./res/res_fax.c: <para>Filename of the image being sent/recieved for this FAX session. This field is not
./res/res_fax.c: <para>Total number of bad lines sent/recieved during this session. This field is not
./doc/core-en_US.xml: <para>Filename of the image being sent/recieved for this FAX session. This field is not
./doc/core-en_US.xml: <para>Total number of bad lines sent/recieved during this session. This field is not
{noformat}

{noformat}
./apps/app_minivm.c: /* If there's a server e-mail address in the account, user that, othterwise template */
{noformat}

By: Walter Doekes (wdoekes) 2015-08-26 04:09:32.886-0500

{noformat}
main/audiohook.c: Rebuild translation path if different format then previously
{noformat}

By: Walter Doekes (wdoekes) 2016-01-25 04:36:28.930-0600

{noformat}
git show 77936f61 | grep ^+
+++ b/include/asterisk/ast_version.h
+/*! Retreive the Asterisk build options */
+const char *ast_get_build_opts(void);
{noformat}

By: Walter Doekes (wdoekes) 2016-02-26 07:09:39.870-0600

CHANGES:
{noformat}
Added the possibility to set the From: header through the the SIP dial
{noformat}
^-- the + the

By: Joshua C. Colp (jcolp) 2017-12-20 06:30:22.764-0600

Is this still applicable?

By: Walter Doekes (wdoekes) 2017-12-20 08:41:50.052-0600

They're still typo's.

{noformat}
$ git log -1 --format=oneline
a711ac25f1b6364552aa4fd09d1a16d303fd28f1 Merge "dns_core: Protect against array index violation."
{noformat}
{noformat}
$ wgrep . -E '[Rr]etreive|[Rr]ecieve' | sed -e 's/:[[:blank:]]*/: /'
./res/res_fax.c: <para>Filename of the image being sent/recieved for this FAX session. This field is not
./res/res_fax.c: <para>Total number of bad lines sent/recieved during this session. This field is not
./main/astobj2.c: * could have been waiting for a lock on weakproxy to retreive
./main/security_events.c: <parameter name="RecievedHash" required="false">
./include/asterisk/ast_version.h: /*! Retreive the Asterisk build options */
./include/asterisk/astobj2.h: * \param obj The object to retreive a weakproxy from
./include/asterisk.h: /*! Retreive the 'struct ast_module *' for the current module. */
{noformat}
{noformat}
$ wgrep . -E ' the the ' | wc -l
21
{noformat}
{noformat}
$ wgrep . -E ' (other|different) then' | sed -e 's/:[[:blank:]]*/: /'
./main/db.c: * First, the parameter binding syntax used here is slightly different then the other
./channels/chan_unistim.c: if (d->ssub[i] != NULL) { /* Found other subchannel active other then hangup'ed one */
{noformat}
{noformat}
$ wgrep . 'othterwise' | sed -e 's/:[[:blank:]]*/: /'
./apps/app_minivm.c: /* If there's a server e-mail address in the account, use that, othterwise template */
{noformat}

By: Corey Farrell (coreyfarrell) 2017-12-20 11:08:20.428-0600

A bunch of those retreives are mine so I'm preparing a review for this.

By: Friendly Automation (friendly-automation) 2017-12-21 08:35:37.223-0600

Change 7687 merged by Jenkins2:
Fix Common Typo's.

[https://gerrit.asterisk.org/7687|https://gerrit.asterisk.org/7687]

By: Friendly Automation (friendly-automation) 2017-12-21 08:38:01.726-0600

Change 7686 merged by Jenkins2:
Fix Common Typo's.

[https://gerrit.asterisk.org/7686|https://gerrit.asterisk.org/7686]

By: Friendly Automation (friendly-automation) 2017-12-21 08:41:27.197-0600

Change 7685 merged by Jenkins2:
Fix Common Typo's.

[https://gerrit.asterisk.org/7685|https://gerrit.asterisk.org/7685]