| Summary: | ASTERISK-24288: [patch] - ODBC usage with app_voicemail - voicemail is not deleted after review, hangup | ||
| Reporter: | LEI FU (lei.fu) | Labels: | |
| Date Opened: | 2014-08-29 15:41:43 | Date Closed: | 2015-01-19 20:27:09.000-0600 |
| Priority: | Minor | Regression? | Yes |
| Status: | Closed/Complete | Components: | Applications/app_voicemail/IMAP Applications/app_voicemail/ODBC |
| Versions: | 1.8.30.0 11.12.0 12.5.0 13.0.0-beta1 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | ALL | Attachments: | ( 0) voicemail_odbc_review_fix.diff ( 1) voicemail_review.patch |
| Description: | When using ODBC storage, operator and review enabled, after leaving a voicemail message, press 0 to enter the menu(press 1 to save the message), then hold about 4 seconds until it prompt "message deleted", but if you hang up the call, you will find the message is still there.
Fixed by attached path | ||
| Comments: | By: Rusty Newton (rnewton) 2014-09-02 18:30:52.058-0500 This looks like a simple patch, however I know many devs consider app_voicemail tricky. Do you want to continue the [Code Review|https://wiki.asterisk.org/wiki/display/AST/Code+Review] process and put your patch on Reviewboard? By: Matt Jordan (mjordan) 2014-09-03 09:35:16.403-0500 While I haven't tested the patch (that is, I'm not sure if we should be unilaterally disposing of the file in that branch), I can say the patch is not the right way to fix that problem. The proper way of deleting a file on disk when using ODBC or IMAP storage is to use the DISPOSE macro. Assuming the problem occurs as the issue describes, the proposed patch would fix this for ODBC (in a non-recommended fashion) but leave the problem intact for IMAP, which is hardly ideal. By: LEI FU (lei.fu) 2014-09-05 10:56:47.809-0500 I use DISPOSE instead, tested with ODBC and file storage, but I didn't test with IMAP By: Matt Jordan (mjordan) 2015-01-19 20:21:12.693-0600 Patch looks correct to me. Thanks for the contribution! | ||