| Summary: | ASTERISK-24294: [patch] Certificate Generation Script | ||
| Reporter: | Slava Bendersky (volga629) | Labels: | patch |
| Date Opened: | 2014-09-02 10:33:33 | Date Closed: | |
| Priority: | Minor | Regression? | |
| Status: | Open/New | Components: | Contrib/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Bash 4 | Attachments: | ( 0) CertMng_rev2 ( 1) cert-mng.diff |
| Description: | Hello Everyone,
I want contribute CertMng script. Which will create setup and maintain certificates for asterisk. It working with additional dns names and ips also can convert to p12 jks ( example jitsi). It can maintain revocation list. I tested script in my environment with TLS authentication and with asterisk behind nat and without it and working as expected. Please test it and include it to Contrib | ||
| Comments: | By: Slava Bendersky (volga629) 2014-09-02 10:35:34.596-0500 This Certificate Manager script. By: Richard Mudgett (rmudgett) 2014-09-02 11:01:50.344-0500 You need to sign the contribution license agreement if you have not already done so. Then you may need to reattach the script once the agreement is accepted. By: Slava Bendersky (volga629) 2014-09-02 11:50:59.517-0500 Ok, I signed. As soon I will re submit as soon all legal paper work will be completed. By: Slava Bendersky (volga629) 2014-09-02 11:52:33.115-0500 Contribution Licence Signed Agreement. By: Slava Bendersky (volga629) 2014-09-02 11:54:02.766-0500 Uploaded again, please review it. By: Rusty Newton (rnewton) 2014-09-02 18:41:16.453-0500 Thanks it'll probably be tomorrow before it gets processed. By: Slava Bendersky (volga629) 2014-09-04 10:32:10.525-0500 I did few small corrections in file names. By: Rusty Newton (rnewton) 2014-09-10 16:41:25.152-0500 [~volga629] thanks for being patient through the legal process! Even though this is a contributed script and not a patch to Asterisk you still probably want to put it on [Reviewboard|https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage] per the [Code Revew|https://wiki.asterisk.org/wiki/display/AST/Code+Review] process. Once you get it on reviewboard you can edit your JIRA issue and add the reviewboard URL in the appropriate Reviewboard field. Thanks! By: Matt Jordan (mjordan) 2014-09-12 11:16:08.658-0500 # This definitely would be nice to have the contrib/scripts folder - I think it is a great idea # That being said, the script is sufficiently complex enough that it probably should go through a formal review process. A number of folks would probably like to have a chance to review it - so I think putting it up for review really would be the right next step. By: Slava Bendersky (volga629) 2014-09-29 09:14:14.817-0500 Hello Everyone, I was busy with different project, I will submit script through formal process today. By: Slava Bendersky (volga629) 2014-10-20 07:51:02.474-0500 I tried submit, but didn't worked. I will some help to submit for review. By: Matt Jordan (mjordan) 2015-01-19 20:14:57.548-0600 The contribution unfortunately is not in the correct format. Patches must be in unified diff format. Instructions for getting a patch generated correctly are on the wiki: https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process Please re-attach the submission in the correct format. Thanks! By: Slava Bendersky (volga629) 2015-01-19 22:02:44.405-0600 Hello Matt, I uploaded in patch/diff format, also please open code review for it. By: Matt Jordan (mjordan) 2015-02-02 09:10:39.053-0600 [~volga629]: Don't forget to hit the "Send Back" button when you've entered in feedback. Otherwise, bug marshals might miss the feedback :-) The patch looks to be in the right format. If you'd like to submit it for formal review, you can push it up for code review on [https://reviewboard.asterisk.org] using the instructions on the wiki here: https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage | ||