Summary:	ASTERISK-24352: Problem with SIP privacy - fromdomain
Reporter:	Krzysztof Chmielewski (kristoff)	Labels:
Date Opened:	2014-09-24 05:47:24	Date Closed:	2014-09-30 14:00:00
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:	11.10.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	Hi, i think there is a problem with SIP privacy in from header. To be more specific, problem concerns fromdomain part of sip message. According to RFC fromdomain should be set to: anonymous.invalid Unfortunately that only works when configuration for this peer leaves "fromdomain"  empty. In other case fromdomain is overwritten. I think this is why: chan_sip.c {code} /* Allow domain to be overridden */ if (!ast_strlen_zero(p->fromdomain)) d = p->fromdomain; else /* Save for any further attempts */ ast_string_field_set(p, fromdomain, d); {code} Earlier we have condition checking if there are any privacy settings on. If fromdomain empty (in my db config for this peer) fromdomain is set to anonymous.invalid. There will be no problem if we have any method to change fromdomain otherwise that through configuration.
Comments:	By: Mark Michelson (mmichelson) 2014-09-30 09:54:53.291-0500 {{fromdomain}} and {{fromuser}} are used frequently to fulfill requirements that certain SIP providers impose. For instance, certain providers may require you to have the domain of your From header set to a specific IP address or hostname in order for the provider to recognize that the incoming request is from you. These options are intended to override typical RFC 3261 behavior since otherwise, we could undermine the requirements that the providers have. So for what you are reporting, I feel this is not a bug. If you wish for the domain in the From header to contain anonymous information for private caller ID, then do not provide a {{fromdomain}} in sip.conf. If we changed the current behavior, it would certainly cause many working configurations to break as a result. By: Rusty Newton (rnewton) 2014-09-30 14:00:40.159-0500 Sounds like this isn't a bug report and is more along the lines of a feature request. Feature requests are no longer submitted to or accepted through the issue tracker. Features requests are openly discussed on the mailing lists [1] and Asterisk IRC channels and made note of by Bug Marshals. [1] http://www.asterisk.org/support/mailing-lists Closing this out as Not A Bug.