| Summary: | ASTERISK-24354: AMI sendMessage closes AMI connection on error | ||
| Reporter: | Peter Katzmann (pk16208) | Labels: | Asterisk12 |
| Date Opened: | 2014-09-25 07:45:45 | Date Closed: | 2014-10-06 13:39:55 |
| Priority: | Major | Regression? | Yes |
| Status: | Closed/Complete | Components: | Core/ManagerInterface |
| Versions: | 11.13.0 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | ubuntu precise | Attachments: | ( 0) sendMessage.patch |
| Description: | Nearly all AMI functions only report an error on failure but do not interrupt the connection.
The new AMI sendMessage instead reports the error and returns -1 which closes the connection. A better approach would be to do it like neraly all other AMI functions, report the error and returning 0 so the connection keeps alive | ||
| Comments: | By: Peter Katzmann (pk16208) 2014-09-25 07:51:09.677-0500 Just return 0 to avoid connection close By: Rusty Newton (rnewton) 2014-09-25 08:48:31.513-0500 Thanks [~pk16208] By: Rusty Newton (rnewton) 2014-09-25 08:51:06.292-0500 Looks like a super simple patch, but feel free to go ahead and put it on Reviewboard to help get it pushed through. https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage By: Peter Katzmann (pk16208) 2014-09-25 09:05:12.029-0500 Hmm, this review board is quite confusing to me By: Matt Jordan (mjordan) 2014-09-25 09:34:37.067-0500 What confusion are you having? By: Peter Katzmann (pk16208) 2014-09-25 09:41:35.625-0500 Usability ? What is this Base Directory ? By: Peter Katzmann (pk16208) 2014-09-26 02:00:32.724-0500 Ok, now on reviewboard https://reviewboard.asterisk.org/r/4024/ By: Richard Mudgett (rmudgett) 2014-09-26 09:32:08.182-0500 I think you need to set the groups field to asterisk-dev for people to see it. You likely need to fill in the branch and bugs fields as well. By: Richard Mudgett (rmudgett) 2014-09-26 14:05:11.850-0500 I was talking about your reviewboard review. Nobody can see it. You need to set the groups field to asterisk-dev. You likely also need to fill in the branch field with 11 and the bugs field with ASTERISK-24354. | ||