[Home]

Summary:ASTERISK-24355: [patch] chan_sip realtime uses case sensitive column comparison for 'defaultuser'
Reporter:HZMI8gkCvPpom0tM (y2fbo4IevYm5Ve9u)Labels:
Date Opened:2014-09-25 08:24:51Date Closed:2015-01-23 09:41:01.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:1.8.31.0 12.5.0 12.5.1 12.6.0 13.0.0-beta2 13.0.0 13.0.1 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast.patch
( 1) chan_sip.patch
( 2) chan_sipcasecmp.patch
Description:chan_sip.c have small issue in function

\[edit\]: inline patch removed - mjordan

This change will fix following problems :
1) constant fail of outgoing Invite authorisation in case of using ODBC
2) Empty  Def. Username will be correctly filled in in case of using ODBC.
May be somebody be happy due to it.

Sorry cannot create patch.

info for people who want just to fix issue and not want to wait untill all departments of Digium at last start to work
function build_peer
!strcmp(v->name, "defaultuser"))  need to change to !strcasecmp(v->name, "defaultuser"))

Comments:By: Matt Jordan (mjordan) 2014-09-25 09:35:48.203-0500

We cannot accept patches in-line in issues.

Why can you not create a patch with your suggestion?
By: HZMI8gkCvPpom0tM (y2fbo4IevYm5Ve9u) 2014-09-25 11:04:37.620-0500

Because i never did it before and not know how. Ok. I ll try to google for it.

[Edit by Rusty - Removing inline patch again - See the guidelines for patch contribution] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process
By: Rusty Newton (rnewton) 2014-10-22 12:11:02.050-0500

Suspended due to lack of activity. Please request a bug marshal in #asterisk-bugs on the IRC network irc.freenode.net to reopen the issue should you have the additional information requested.  Further information can be found at http://www.asterisk.org/developers/bug-guidelines


By: Walter Doekes (wdoekes) 2014-11-07 04:00:48.995-0600

I'm sorry, but it looks to me like your table definition is simply wrong.

If the column name says 'defaultuser' (lowercase), everything should work fine without this patch.


By: Walter Doekes (wdoekes) 2014-11-07 04:03:03.526-0600

I'm reopening this. Although right now it looks should probably be closed as "Not a bug".
By: Walter Doekes (wdoekes) 2014-11-07 04:06:39.365-0600

Ok. I retract that. You're right. All other options are queried insensitively, so this one should be too.

Unfortunately asterisk 1.8 has gone into security-fix-only mode. But I can apply this to asterisk11 and up.
By: HZMI8gkCvPpom0tM (y2fbo4IevYm5Ve9u) 2014-11-28 03:44:13.654-0600

patch for 13.0.1