Summary:	ASTERISK-24372: [patch] Add config option to play a prompt to the "winner" in app_followme
Reporter:	Graham Mainwaring (ghjm)	Labels:	patch
Date Opened:	2014-09-29 19:26:02	Date Closed:	2018-01-18 09:10:42.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Applications/app_followme
Versions:	SVN 13.18.4	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_followme.patch
Description:	This patch adds the ability to configure a prompt which will be read to the "winner" who pressed 1 (or the configured value) and received the call. The context of this is that I have users who only receive outbound follow-me calls occasionally. These users have complained that when they are connected to the inbound caller, they don't always remember to say hello as if the call just arrived, so there is an awkward moment where the two parties figure out they are connected. My prompt here says "Connecting. After the beep, please say hello to the caller. <beep>." This reminds the follow-me winner that they ought to say hello. I have configured this with a default of silence/0 so that the system's behavior will not change for anyone who does not have this configured.
Comments:	By: Rusty Newton (rnewton) 2014-10-01 12:13:13.409-0500 Looks like a useful option. Be sure this works with Trunk and note that adding configuration options requires documentation of the options as well. In this case, for {{configs/followme.conf.sample}}. Then you can follow the [Code Review|https://wiki.asterisk.org/wiki/display/AST/Code+Review] process and get them on Reviewboard for others to review and test. Thanks! By: Rusty Newton (rnewton) 2014-10-01 12:14:05.455-0500 Remember to edit this JIRA issue and add the Reviewboard URL to the Reviewboard field. By: Graham Mainwaring (ghjm) 2014-10-19 15:09:29.598-0500 I have updated the patch to include documentation in the sample config file, and will put it on Reviewboard shortly. The patch is against trunk from SVN today. By: Matt Jordan (mjordan) 2015-01-19 20:16:12.241-0600 So, I was going through the various issues with patches, and came across this one. It looks like this was never pushed to review board, as the review board post has no diff and is still in an unpublished state. Were you interested in having the contribution reviewed? Generally, patches that go through code review get included much faster into the project. By: Graham Mainwaring (ghjm) 2015-01-19 23:18:27.218-0600 Yes, I am still interested in this patch. I guess I never completed the Reviewboard process - I have published it now. Thanks for the reminder. By: Joshua C. Colp (jcolp) 2017-12-18 09:34:18.855-0600 [~ghjm] [~rmudgett] had some comments on your original reviewboard review. Would you like to take care of them and put this up under our new review process? By: Graham Mainwaring (ghjm) 2017-12-27 17:59:02.947-0600 I have tried to go through the process as best I can figure it out. By: Graham Mainwaring (ghjm) 2017-12-27 18:24:34.196-0600 Ok, so now I have https://gerrit.asterisk.org/#/c/7741/ which has passed Jenkins verification. What am I to do next? By: Joshua C. Colp (jcolp) 2017-12-27 18:26:27.889-0600 The change will be reviewed and comments left on it. Some may be actionable (requiring a change or such). Just keep watching there. By: Friendly Automation (friendly-automation) 2018-01-18 09:10:43.783-0600 Change 7741 merged by Jenkins2: app_followme:  Add a prompt to be read when a call is connected [https://gerrit.asterisk.org/7741|https://gerrit.asterisk.org/7741] By: Friendly Automation (friendly-automation) 2018-01-18 09:12:51.761-0600 Change 8005 merged by Jenkins2: app_followme:  Add a prompt to be read when a call is connected [https://gerrit.asterisk.org/8005|https://gerrit.asterisk.org/8005] By: Friendly Automation (friendly-automation) 2018-01-18 09:17:53.768-0600 Change 8006 merged by Jenkins2: app_followme:  Add a prompt to be read when a call is connected [https://gerrit.asterisk.org/8006|https://gerrit.asterisk.org/8006]