Summary: | ASTERISK-24393: rtptimeout=0 doesn't disable rtptimeout | ||
Reporter: | Dmitry Melekhov (slesru) | Labels: | |
Date Opened: | 2014-10-06 05:25:02 | Date Closed: | 2014-10-15 05:04:50 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | Addons/chan_ooh323 |
Versions: | 11.10.2 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | centos 6/x86-64 | Attachments: | ( 0) ASTERISK-24393.patch ( 1) ooh323.conf |
Description: | Hello!
I have {{rtptimeout=0}} in {{ooh323.conf}}, but just seen this on console: {noformat} [Oct 6 14:05:46] NOTICE[7230]: chan_ooh323.c:3952 do_monitor: Disconnecting call 'OOH323/192.168.135.251-18' for lack of RTP activity in 61 seconds {noformat} I though that rtptimeout=0 will disable timeout , because of this code {noformat} if (h323->rtp && h323->owner && h323->rtptimeout {noformat} but looks like for some reason it is not set from config file (may be I mistyped it?) and , unfortunately, ooh323 show config doesn't show rtptimeout value. Thank you! | ||
Comments: | By: Matt Jordan (mjordan) 2014-10-06 11:00:53.703-0500 Please attach your {{ooh323.conf}} file - without knowing where you placed the {{rtptimeout}} parameter, it is difficult to tell if this is a bug or a mis-configuration. By: Dmitry Melekhov (slesru) 2014-10-06 13:08:49.914-0500 my config By: Dmitry Melekhov (slesru) 2014-10-06 13:09:18.481-0500 Hello! Uploaded, thank you! By: Rusty Newton (rnewton) 2014-10-06 15:17:09.302-0500 Chan_ooh323, assigning to [~may213] for triage. By: Alexander Anikin (may213) 2014-10-07 02:29:12.254-0500 Hello, It's trivial bug in reload_config function: } else if (!strcasecmp(v->name, "rtptimeout")) { gRTPTimeout = atoi(v->value); if (gRTPTimeout <= 0) gRTPTimeout = 60; Must be 'if (gRTPTimeout < 0)' not <= It's actual only for rtptimeout=0 and only for [general] section. Will fix it. By: Dmitry Melekhov (slesru) 2014-10-07 04:01:10.589-0500 Thank you! just started testing on one of my asterisks :-) By: Dmitry Melekhov (slesru) 2014-10-07 05:10:29.128-0500 don't see such messages anymore on console, have to change other asterisks :-) thank you! By: Alexander Anikin (may213) 2014-10-07 05:56:48.516-0500 The patch attached By: Dmitry Melekhov (slesru) 2014-10-08 01:03:20.467-0500 thank you! as I already said it works . hope to see it in next asterisk releases :-) |