Summary:	ASTERISK-24572: [patch]App_meetme is loaded without its defaults when the configuration file is missing
Reporter:	Nuno Borges (nerbos)	Labels:
Date Opened:	2014-12-01 06:18:29.000-0600	Date Closed:	2014-12-06 11:22:45.000-0600
Priority:	Trivial	Regression?
Status:	Closed/Complete	Components:	Applications/app_meetme
Versions:	SVN 1.8.32.1 11.14.1 12.7.1 13.0.1	Frequency of Occurrence	Constant
Related Issues:	causes ASTERISK-25569 app_meetme: Audio quality issues
Environment:		Attachments:	( 0) 24572.patch
Description:	We had some voice issues when using app_meetme rooms for conferences. We were not exporting the app_meetme configuration file assuming it would load the defaults anyway, but it didn't. Either the module fails to load due to the lack of the configuration file or it should always init its defaults.
Comments:	By: Nuno Borges (nerbos) 2014-12-01 06:20:18.430-0600 Patch to always init the defaults when trying to load the configuration file. By: Matt Jordan (mjordan) 2014-12-02 13:48:56.052-0600 I'm not sure I agree with this patch. With your patch, an invalid configuration file will cause the previous config file's settings to be reset to the default - but then fail to apply the new configuration. That could have some rather nasty consequences - for example, I may have {{logmembercount}} set to {{1}}, modify my config file such that is invalid, issue a reload, and now - instead of simply rejecting the configuration and preserving the previous value of {{logmembercount}} - it will set it to 0 and then fail the config file load. That's worse behaviour than what we have now. I do think you should try to fix this such that - on an initial load only - {{rt_log_members}} is set to {{1}}. But that should only apply on initial load, and not on a reload. On a reload, the previous values should always be preserved if the config file load fails. By: Nuno Borges (nerbos) 2014-12-03 08:19:31.632-0600 Hi, Yes, your point is correct. I have submitted a new patch in order to avoid that bad behaviour. Best regards By: Rusty Newton (rnewton) 2014-12-04 15:55:40.251-0600 I've opened this issue. Note that app_meetme is marked for extended support in all versions of Asterisk supported for bug fixes now. Extended support modules are supported by the broader community and response times may reflect that. Nuno you will want to get your revised patch on Reviewboard so others can review, test and get it pushed in. See the [Code Review process|https://wiki.asterisk.org/wiki/display/AST/Code+Review]. Thanks! By: Rusty Newton (rnewton) 2014-12-04 15:57:00.521-0600 Setting the affected versions based on this likely affecting all of the current branches. By: Nuno Borges (nerbos) 2014-12-05 10:04:34.632-0600 Ok, i've added the reviewboard link. First time i did this, i hope i did it correctly. Best regards.