Summary:	ASTERISK-24626: Voicemail passwords not being stored in ARA
Reporter:	Paddy Grice (paddy.grice)	Labels:
Date Opened:	2014-12-16 15:19:28.000-0600	Date Closed:	2015-01-25 07:43:21.000-0600
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:	13.0.1	Frequency of Occurrence	Constant
Related Issues:	is caused by ASTERISK-24231 crash: CLI execution of realtime destroy sippeers id 1 causes crash due to NULL name provided to ast_variable is duplicated by ASTERISK-24720 Unable to change voicemail password using realtime engine
Environment:	Debian 7.7 asterisk 13.0.1	Attachments:
Description:	app_voicemail on ARA is not storing password changes in the db. A little hair pulling and playing around and I think the problem is in the function {{ast_update2_realtime}} in main/config.c. Issued source is ==> {noformat} int ast_update2_realtime(const char *family, ...) {         RAII_VAR(struct ast_variable *, lookup_fields, NULL, ast_variables_destroy);         RAII_VAR(struct ast_variable *, update_fields, NULL, ast_variables_destroy);         va_list ap;         va_start(ap, family);         /* XXX: If we wanted to pass no lookup fields (select all), we'd be          * out of luck. realtime_arguments_to_fields expects at least  one key          * value pair. */         realtime_arguments_to_fields(ap, &lookup_fields);         va_end(ap);         va_start(ap, family);         realtime_arguments_to_fields2(ap, 1, &lookup_fields);         va_end(ap);         if (!lookup_fields || !update_fields) {                 return -1;         }         return ast_update2_realtime_fields(family, lookup_fields, update_fields); } {noformat} I believe line 3314 of the file main/config.c should be {noformat}         realtime_arguments_to_fields2(ap, 1, &update_fields); {noformat}
Comments:	By: Rusty Newton (rnewton) 2014-12-16 18:04:05.637-0600 We require a complete debug log to help triage the issue. This document will provide instructions on how to collect debugging logs from an Asterisk machine for the purpose of helping bug marshals troubleshoot an issue: https://wiki.asterisk.org/wiki/display/AST/Collecting+Debug+Information By: Rusty Newton (rnewton) 2014-12-16 18:07:09.068-0600 Make sure to attach the log to the issue and verify that DEBUG logger channels are present in the log. By: Rusty Newton (rnewton) 2014-12-30 19:18:18.561-0600 Additionally, you make a suggestion for a code change here. Did you test it out? Can you provide a patch? https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process By: Matt Jordan (mjordan) 2015-01-19 21:02:53.812-0600 Your analysis looks correct to me. I'm going to go ahead and put together a patch for this. Thanks! By: Matt Jordan (mjordan) 2015-01-19 21:06:50.629-0600 Updated with link to review board.