Summary:	ASTERISK-24857: [patch] "timing test", pjsip incoming/outgoing calls, voicemail prompts and recordings all fail when using the kqueue timer source on FreeBSD 10.x
Reporter:	Justin T. Gibbs (scsiguy)	Labels:
Date Opened:	2015-03-09 12:31:58	Date Closed:	2015-03-27 09:43:47
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Resources/res_timing_kqueue
Versions:	13.2.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	FreeBSD 10-stable.	Attachments:
Description:	Using the kqueue timing source results in glitchy audio and failed calls. [Edit by Rusty - adding your Reviewboard description info here for more "searchability"] Reviewboard patch description: {quote} Update the kqueue timing module to conform to current timer API. This fixes issues with using the kqueue timing source on Asterisk 13 on FreeBSD 10. res_timing_kqueue.c: Remove support for kevent64().  The values used to support Asterisk timers fit within 32bits and so can be handled on all platforms via kevent(). Provide debug logging for, but do not track, unacked events.  This matches the behavior of all other timer implementations. Implement continuous mode by triggering and leaving active, a user event.  This ensures that the file descriptor for the timer returns immediately from poll(), without placing the load of a high speed timer on the kernel. In kqueue_timer_get_max_rate(), don't overstate the capability of the timer.  On some platforms, UINT_MAX is greater than INTPTR_MAX, the largest integer type kqueue supports for timers. In kqueue_timer_get_event(), assume the caller woke up from poll() and just return the mode the timer is currently in.  This matches all other timer implementations. Adjust the test code now that unacked events are not tracked. {quote} Testing done: {quote} Asterisk 13.2.0 on FreeBSD 10-stable: "timing test", pjsip incoming/outgoing calls, voicemail prompts and recordings.  All of the above failed without these changes. {quote}
Comments:	By: Matt Jordan (mjordan) 2015-03-10 16:12:15.671-0500 Can you provide a bit more explanation about what is wrong in the timing module? As it is, if someone searches for this issue in the issue tracker, they are highly unlikely to find this issue or know if their problem is similar to this one. By: Matt Jordan (mjordan) 2015-03-27 09:42:11.036-0500 Merged to 13+. Thanks for the contribution!