[Home]

Summary:ASTERISK-24862: [patch] Support in-dialog OPTIONS
Reporter:yaron nahum (yaronna)Labels:
Date Opened:2015-03-11 08:43:57Date Closed:2015-04-09 10:44:31
Priority:MajorRegression?
Status:Closed/CompleteComponents:Channels/chan_pjsip
Versions:SVN Frequency of
Occurrence
Related
Issues:
duplicatesASTERISK-24818 PJSIP in dialog OPTIONS method handling
Environment:Attachments:( 0) res_pjsip_dlg_options.c
Description:This is a session supplement that adds the ability to respond session keepalive mechanism implemented by sending OPTIONS message periodically. In order to keep the session alive the asterisk should respond with 200OK. Currently the PJSIP channel is not responding at all.
Comments:By: Rusty Newton (rnewton) 2015-03-13 17:37:35.725-0500

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]
* As this is a new feature, please read the New Feature Guidelines [5]
* Make sure your new feature applies cleanly to Asterisk trunk

When ready, submit your patch and any tests to Review Board [6] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines
[6] https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage



By: Joshua C. Colp (jcolp) 2015-04-09 09:04:17.264-0500

A testsuite test is now available for this at https://gerrit.asterisk.org/#/c/37/

By: Matt Jordan (mjordan) 2015-04-09 10:43:25.308-0500

New module submitted to 13/trunk. Thanks for the contribution!