[Home]

Summary:ASTERISK-24887: [patch]tags in a=crypto lines do not accept 2 or more digits
Reporter:Makoto Dei (makoto)Labels:
Date Opened:2015-03-16 23:24:41Date Closed:2015-05-21 09:53:15
Priority:MinorRegression?
Status:Closed/CompleteComponents:Channels/chan_sip/SRTP
Versions:11.17.0 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Attachments:( 0) sip-crypto-tag.patch
Description:RFC 4568 Section 9.1 (https://tools.ietf.org/html/rfc4568#section-9.1) says:

  "a=crypto:" tag 1*WSP crypto-suite 1*WSP key-params
                                          *(1*WSP session-param)

  tag              = 1*9DIGIT


So valid tag is between 0 and 999999999.
But SDP parser of chan_sip accepts only tag between 1 and 9.

Attached patch will fix the problem.
Comments:By: Matt Jordan (mjordan) 2015-03-26 17:13:53.442-0500

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]

When ready, submit your patch and any tests to Review Board [5] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage