Summary:	ASTERISK-24897: Confbridge dtmf_passthrough is not respected when using menus
Reporter:	Dennis (Cine)	Labels:
Date Opened:	2015-03-20 06:17:57	Date Closed:	2020-01-20 15:47:47.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Bridges/bridge_softmix
Versions:	12.8.1 13.2.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	If starting a confbridge with dtmf_passthrough=yes and a menu, then dtmf tones are not passed through. bridge_handle_dtmf in bridge_channel.c should not free the frame, but just return it always. or alternatively, a warning should be put in log when bridge_channel->features->dtmf_passthrough is true and frame is false in bridge_handle_trip.
Comments:	By: Matt Jordan (mjordan) 2015-03-22 18:28:55.800-0500 Sounds like you already have an idea on what the fix would be. Do you have a proposed patch for the issue? By: Rusty Newton (rnewton) 2015-04-08 09:44:59.982-0500 If you do decide to submit a patch: Once you've followed the Code Review process [1] and submitted your code to Review Board [2] be sure to edit this JIRA issue and add the Review Board review URL in the appropriate field. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Code+Review [2] https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage By: Richard Mudgett (rmudgett) 2015-04-08 10:47:52.632-0500 I think this is a misinterpretation of the {{dtmf_passthrough}} feature.  Since there are no logs to show the reported problem I cannot say for certain.  ConfBridge will collect digits that partially match a menu item until either no menu item match is possible or a menu item is matched.  If the collected digits cannot match a menu item then the collected digits are passed into the bridge when pass through is enabled.  If the collected digits match a menu item then they are eaten by the menu item as those digits were not meant for the bridge but the menu item. By: Sean Bright (seanbright) 2020-01-20 15:47:47.326-0600 Based on [~rmudgett]'s comments, this is a misunderstanding and not a bug.