Summary:	ASTERISK-24906: [patch] Asterisk doesn't compile under Cygwin
Reporter:	Manuel Meitinger (meitinger)	Labels:	patch
Date Opened:	2015-03-24 13:41:10	Date Closed:	2020-12-29 08:04:05.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:	13.2.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	Cygwin 1.7.35	Attachments:	( 0) asterisk-13.2.0-win.patch
Description:	Things that need to be changed: - minor {{-l...}} corrections in {{*/Makefile}} - a lot of dependency hints in {{res/Makefile}} - remove outdated cygload in {{main/Makefile}} - remove outdated definition in {{compat.h}} - disable unsupported malloc backtrace in {{utils.h}} - don't use {{dlsym}} in {{libasteriskssl.c}} - don't use {{g+++}} to link (which brings in the std c+++ lib, and a lot of libm conflicts) - disable beep in {{res_monitor.c}} - use different mutex defines in {{lock.h}} Things that should be changed:  {{--disable-asteriskssl}} should default to true on Cygwin
Comments:	By: Rusty Newton (rnewton) 2015-03-24 18:02:03.310-0500 Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to: * Verify that your patch conforms to the Coding Guidelines [2] * Review the Code Review Checklist [3] for common items reviewers will look for * If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4] When ready, submit your patch and any tests to Review Board [5] for code review. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Code+Review [2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines [3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist [4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation [5] https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage By: Rusty Newton (rnewton) 2015-03-24 18:03:01.607-0500 Also, a quick note that patches need to be attached to the issue and marked as a code contribution. This is mentioned in the documentation linked above. Thanks! By: Manuel Meitinger (meitinger) 2015-03-26 10:31:41.117-0500 Added patch as file (my license agreement has finally been accepted, yay :) By: Manuel Meitinger (meitinger) 2015-03-26 10:48:45.728-0500 Thanks for the detailed response, @Rusty Newton. I'll go through the review process as soon as I have some more time to spare on this issue, especially since a change to {{configure.ac}} in order to enable {{--disable-asteriskssl}} if {{PBX_WINARCH}} is set should also be included in the patch. By: Rusty Newton (rnewton) 2015-04-13 14:35:27.699-0500 Thanks. Getting it on reviewboard will greatly increase the odds of this getting in. By: Asterisk Team (asteriskteam) 2020-12-29 08:04:06.239-0600 Cygwin is no longer a platform being supported by any individual or being persued, so I am closing out this issue.