Summary: | ASTERISK-24948: Review Board 4457 isn't merged to Asterisk 11 branch | ||
Reporter: | ibercom (ibercom) | Labels: | |
Date Opened: | 2015-04-09 04:40:11 | Date Closed: | 2015-04-09 13:22:54 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | Core/General |
Versions: | 11.17.0 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ||
Description: | The following change should be merged to Asterisk 11 branch:
https://reviewboard.asterisk.org/r/4457/ It is simple and directly applicable. This has already been applied to other modules: {code} ast_register_cleanup(translate_shutdown); {code} | ||
Comments: | By: Corey Farrell (coreyfarrell) 2015-04-09 11:06:01.117-0500 This was fixed through r433495. I do not think it is needed to set __matrix or __indexable to NULL, as we are not doing the cleanup during fast shutdown anyways. By: ibercom (ibercom) 2015-04-09 13:09:00.682-0500 Sorry, I had not seen that change had been applied later. Set __matrix or __indexable to NULL could be interesting to maintain similar changes to the code. This may be closed. By: Corey Farrell (coreyfarrell) 2015-04-09 13:22:54.732-0500 I have to learn towards saying that the NULL's are unneeded now that shutdown is all or nothing. |