| Summary: | ASTERISK-24952: global timerb is disregarded by chan_sip | ||
| Reporter: | yarique (yarique) | Labels: | |
| Date Opened: | 2015-04-11 13:14:47 | Date Closed: | |
| Priority: | Minor | Regression? | |
| Status: | Open/New | Components: | Channels/chan_sip/General |
| Versions: | 11.17.1 13.3.2 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Global timerb setting in sip.conf never has effect. It is obvious from chan_sip.c why:
{code} } else if (!strcasecmp(v->name, "timerb")) { int tmp = atoi(v->value); if (tmp < 500) { global_timer_b = global_t1 * 64; ast_log(LOG_WARNING, "Invalid value for timerb ('%s'). Setting to default ('%d').\n", v->value, global_timer_b); } timerb_set = 1; } {code} [\Edit\] *inline patch removed* Thank you. | ||
| Comments: | By: Matt Jordan (mjordan) 2015-04-11 23:21:26.372-0500 We can't accept inline patches or patches in issue descriptions. Please attach a patch for the issue after signing a CLA. By: yarique (yarique) 2015-04-12 09:46:29.933-0500 Please feel free to fix the obvious bug without looking at my 'patch'. Sorry but I don't think I can sign your CLA due to my legal commitments elsewhere. | ||