| Summary: | ASTERISK-25028: Build System: Unneeded defines in asterisk/buildopts.h | ||
| Reporter: | Corey Farrell (coreyfarrell) | Labels: | |
| Date Opened: | 2015-04-29 02:52:45 | Date Closed: | 2015-04-29 09:49:07 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Core/BuildSystem |
| Versions: | SVN | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | build_tools/make_buildopts_h contains a loop to generate defines {{AST_MODULE_*}} for all modules listed as {{MENUSELECT_BUILD_DEPS}}. These defines are not used anywhere.
When enabling or disabling any effected module {{asterisk/buildopts.h}} changes, so all sources will rebuild. ccache is no help in this rebuild - you will get 100% cache misses. Since the proposed fix removes existing defines and changes the AST_BUILDOPT_SUM it is for master only. Without changes to the way AST_BUILDOPT_SUM is generated there is no point. | ||
| Comments: | |||