[Home]

Summary:ASTERISK-25030: Avoid using LIKE when using realtime engine
Reporter:Mickael Marrache (Miko95)Labels:
Date Opened:2015-04-29 07:03:35Date Closed:2017-08-24 10:11:11
Priority:MinorRegression?
Status:Closed/CompleteComponents:Applications/app_directory Applications/app_followme Applications/app_meetme Applications/app_queue Channels/chan_sip/DatabaseSupport PBX/pbx_realtime
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Avoid using LIKE when performing regex lookups using realtime engine.

I think that the value should have a special format indicating it is a regular expression. For example, starting and ending with / (forward slash). In such case, the value should be interpreted as a regular expression by the realtime engine implementation (which may not only be a relational database that supports the well known LIKE keyword).
Comments:By: Rusty Newton (rnewton) 2015-04-30 18:54:46.847-0500

Features requests without patches are not accepted through the issue tracker. Features requests are openly discussed on the mailing lists, forums, and IRC [1]. Please see the Asterisk Issue Guidelines [2] for more information on feature request and patch submission.

[1] http://asterisk.org/community/discuss
[2] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines



By: Rusty Newton (rnewton) 2015-04-30 18:55:55.714-0500

[~Miko95] do you have a patch you would like to submit? If so I'll leave this open while you prepare it and follow the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Thanks!

By: Mickael Marrache (Miko95) 2015-05-01 01:17:28.943-0500

I would not call this a feature request but an improvement. The way it is designed now complicates implementation of new realtime engines that work with databases that don't support the LIKE keyword. I encountered this issue while implementing a reatime engine working with MongoDB.

Regarding the patch contribution process, I would rather attach a patch directly to this ticket.

By: Rusty Newton (rnewton) 2015-05-15 08:59:24.813-0500

In terms of contribution and how we marshal issues through the tracker we treat feature requests and improvements the same. Both require a patch (or someone actively developing one) to move forward.

You are welcome to attach a patch only to this ticket if that as far as you are willing to go. Someone else may be willing to move it through the rest of the process, such as peer review and eventually pushing it into Asterisk. However, the odds of the improvement getting in are much greater if the author pushes it through peer review.

I'll leave this in waiting for feedback until you attach your patch. Thanks!

By: Rusty Newton (rnewton) 2015-06-16 14:49:45.492-0500

[~Miko95] I haven't seen any activity on this issue. Is this something you will be working on in the near future? Or should we close this one out and wait until you are ready.  We don't track feature or improvement requests unless someone is actively working them (or will be soon).

By: Asterisk Team (asteriskteam) 2015-07-01 12:00:20.586-0500

Suspended due to lack of activity. Please request a bug marshal in #asterisk-bugs on the IRC network irc.freenode.net to reopen the issue should you have the additional information requested. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines

By: Sean Bright (seanbright) 2017-03-25 11:31:32.223-0500

[~Miko95], can you tell me where we are using {{LIKE}} with regular expressions?