Summary:	ASTERISK-25118: [patch]PeerStatus Event Unsubscribed with Peer IP Address
Reporter:	Peter Katzmann (pk16208)	Labels:	patch
Date Opened:	2015-05-22 05:09:56	Date Closed:
Priority:	Trivial	Regression?
Status:	Open/New	Components:	Channels/chan_sip/General
Versions:	SVN 11.18.0 13.18.4	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) PeerStatusEventUnsubscribe.patch ( 1) PeerStatusEventUnsubscribe-ast13.patch
Description:	The Asterisk Peer Status event delivers the ip address and port of the peer device only during subscribe. The following patch also adds this information to Unsubscribe event, because asterisk should know the device the user was registered to.
Comments:	By: Peter Katzmann (pk16208) 2015-05-22 05:12:22.950-0500 Patch against asterisk 11.18-rc1 By: Rusty Newton (rnewton) 2015-05-28 19:42:40.476-0500 Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to: * Verify that your patch conforms to the Coding Guidelines [2] * Review the Code Review Checklist [3] for common items reviewers will look for * If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4] * As this is a new feature, please read the New Feature Guidelines [5] * Make sure your new feature applies cleanly to Asterisk trunk When ready, submit your patch and any tests to Gerrit [6] for code review. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Code+Review [2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines [3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist [4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation [5] https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines [6] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage Improvements need to be submitted against 13 or Master. By: Peter Katzmann (pk16208) 2015-05-29 07:54:43.034-0500 Peer Unregister AMI event with IP against asterisk 13 By: Peter Katzmann (pk16208) 2015-05-29 07:56:30.004-0500 Hello Rusty, thanks for your detailed description how to contribute but out firewall policy does make it impossible for me to create a contribution via gerrit. I can only supply a patch against asterisk 13, as already done. By: Rusty Newton (rnewton) 2015-06-01 18:31:29.378-0500 Peter. Thanks for the contribution. If you are unable to push it through then it'll be up to another developer with interest to walk it through then peer review process.