Summary:	ASTERISK-25217: [patch]res_pjsip_outbound_publish.c needs a similar treatment for module unloading as res_pjsip_outbound_registration.c
Reporter:	Richard Mudgett (rmudgett)	Labels:
Date Opened:	2015-06-30 16:34:38	Date Closed:	2016-08-09 14:47:10
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Resources/res_pjsip_outbound_publish
Versions:	13.4.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) jira_asterisk_25217_v13_attempted_fix.patch
Description:	ASTERISK-24907 fixed a crash on module unloading for {{res_pjsip_outbound_registration}}.  A similar treatment needs to be performed to {{res_pjsip_outbound_publish}} to make it safer to unload. # The module needs to use {{ast_sorcery_object_unregister()}}. # The module needs to use its own serializers so it can do a group shutdown on them.  {{ast_serializer_shutdown_group_join()}}  The {{struct unloading_data}} method used in the module is not reliable as the threads may not get out of the module before it gets unloaded.  See the ASTERISK-24514 fix {{664067e3189b29bd00276725d2293363c9b9ebe1}}. # There is a bug in the module's {{unload_module()}} dealing with the return value of {{ast_cond_timedwait()}}.  The attached patch is an attempted fix.
Comments:	By: Asterisk Team (asteriskteam) 2015-06-30 16:34:39.469-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].