Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Applications/app_queue
    • Labels:
      None
    • Mantis ID:
      2563
    • Regression:
      No

      Description

      When AddQueueMember is used to add members to a queue, calls placed to the member immediately connect the caller to the member (or play the queue announcement to the member). This is different from AgentLogin (where the member is always connected), or AgentCallbackLogin (where the member must acknowledge the queue call before being connected).

      This causes a couple of problems:

      • the media path may not yet be established, so part of the announcement message can be lost
      • the agent may not have the handset up to their ear yet

      This patch adds a configurable delay, applied between the agent's channel being brought up and any messages or bridging being done on the channel. The default is for no delay, so there is no behavior change if the option is not used.

        Activity

        Hide
        Mark Spencer added a comment -

        This patch doesn't apply to CVS. Also, you need to check the result of the safe_sleep since a hangup there would be possible.

        Show
        Mark Spencer added a comment - This patch doesn't apply to CVS. Also, you need to check the result of the safe_sleep since a hangup there would be possible.
        Hide
        Mark Spencer added a comment -

        And remember to add [patch] to your titles!

        Show
        Mark Spencer added a comment - And remember to add [patch] to your titles!
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        rediffed against current CVS

        Error checking added for call to ast_safe_sleep, treated the same as if ast_autoservice_stop reports a failure.

        Show
        Kevin P. Fleming (Inactive) added a comment - rediffed against current CVS Error checking added for call to ast_safe_sleep, treated the same as if ast_autoservice_stop reports a failure.
        Hide
        Mark Spencer added a comment -

        Err, hate to send you back again, but you need to do your sleep in the same place that the announce/holdtime is, otherwise you won't have autoservice on the main channel during the pause.

        Show
        Mark Spencer added a comment - Err, hate to send you back again, but you need to do your sleep in the same place that the announce/holdtime is, otherwise you won't have autoservice on the main channel during the pause.
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        Sorry, that's a newbie mistake... new patch uploaded.

        Also, the code I copied that reports a hangup seems to be wrong... it is reacting to an error being returned from the autoservice functions, but if an error is returned it reports that the agent hung up, when in reality it would be the caller that would have hung up (since autoservice is being run on the caller's channel).

        Show
        Kevin P. Fleming (Inactive) added a comment - Sorry, that's a newbie mistake... new patch uploaded. Also, the code I copied that reports a hangup seems to be wrong... it is reacting to an error being returned from the autoservice functions, but if an error is returned it reports that the agent hung up, when in reality it would be the caller that would have hung up (since autoservice is being run on the caller's channel).
        Hide
        Mark Spencer added a comment -

        Added to CVS, with slight mods

        Show
        Mark Spencer added a comment - Added to CVS, with slight mods
        Hide
        Mark Spencer added a comment -

        Added to CVS, with slight mods, thanks!

        Show
        Mark Spencer added a comment - Added to CVS, with slight mods, thanks!
        Hide
        Russell Bryant added a comment -

        not included in the 1.0 branch

        Show
        Russell Bryant added a comment - not included in the 1.0 branch
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 3904

        U trunk/apps/app_queue.c
        U trunk/configs/queues.conf.sample
        U trunk/formats/format_wav_gsm.c

        ------------------------------------------------------------------------
        r3904 | markster | 2008-01-15 15:09:04 -0600 (Tue, 15 Jan 2008) | 2 lines

        Merge member delay patch (bug ASTERISK-2522)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=3904

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 3904 U trunk/apps/app_queue.c U trunk/configs/queues.conf.sample U trunk/formats/format_wav_gsm.c ------------------------------------------------------------------------ r3904 | markster | 2008-01-15 15:09:04 -0600 (Tue, 15 Jan 2008) | 2 lines Merge member delay patch (bug ASTERISK-2522 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3904

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development