Summary: | ASTERISK-25227: No audio at in-band announcements in ooh323 channel | ||
Reporter: | Alexandr Dranchuk (dav) | Labels: | |
Date Opened: | 2015-07-03 06:41:46 | Date Closed: | 2015-09-09 19:15:27 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Addons/chan_ooh323 |
Versions: | 11.18.0 | Frequency of Occurrence | Constant |
Related Issues: | |||
Environment: | Debian 8 / x64 | Attachments: | |
Description: | When incoming call comes to asterisk thru OOH323 channel, the caller can't hear audio at in-band announcements from asterisk. | ||
Comments: | By: Asterisk Team (asteriskteam) 2015-07-03 06:41:47.796-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Alexandr Dranchuk (dav) 2015-07-03 06:52:26.194-0500 After investigating tcpdump I found that OOH323 doesn't sent Progress Indicator field in Progress message, thus many equipment ignore media offered including audio announcements. Progress Indicator field must be set according CISCO documentation I found at http://www.cisco.com/c/en/us/support/docs/voice/h323/22983-ringback.html#progresstones Thus I've update 2 lines of code in ooq931.c at ooEncodeH225Message() function from commented: {code:title=ooq931.c|borderStyle=solid} /*Add progress indicator IE if(pq931Msg->messageType == Q931AlertingMsg || pq931Msg->messageType == Q931CallProceedingMsg) { msgbuf[i++] = Q931ProgressIndicatorIE; msgbuf[i++] = 2; //Length is 2 octet msgbuf[i++] = 0x80; //PI=8 msgbuf[i++] = 0x88; }*/ {code} to {code:title=ooq931.c|borderStyle=solid} /*Add progress indicator IE if(pq931Msg->messageType == Q931AlertingMsg || pq931Msg->messageType == Q931CallProceedingMsg) */ if(pq931Msg->messageType == Q931ProgressMsg) { msgbuf[i++] = Q931ProgressIndicatorIE; msgbuf[i++] = 2; //Length is 2 octet msgbuf[i++] = 0x80; //PI=8 msgbuf[i++] = 0x88; } {code} and it's starts to works as magic. tested at company's equipment, By: Rusty Newton (rnewton) 2015-07-08 15:13:56.462-0500 Assigning to Alexander Anikin (chan_ooh323 maintainer) for triage. By: Alexander Anikin (may213) 2015-08-03 16:04:23.156-0500 Hi, There is such issue on all version of asterisk/chan_ooh323. It will correct to use ProgressIndicator IE not only on Progress but on Alerting Msg also as do it most of h.323 switches. By: Alexandr Dranchuk (dav) 2015-09-09 11:43:57.856-0500 Just want to note that I also test "ProgressIndicator IE not only on Progress but on Alerting Msg also" and report that it's all fine. |