Summary: | ASTERISK-25285: app_voicemail prompts play improperly for Portuguese language | ||
Reporter: | Pedro (pedrodm) | Labels: | |
Date Opened: | 2015-07-28 11:29:39 | Date Closed: | |
Priority: | Trivial | Regression? | |
Status: | Open/New | Components: | Applications/app_voicemail |
Versions: | 11.18.0 13.18.4 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ||
Description: | static int vm_intro_pt
should be equal to static int vm_intro_pt_BR in order to play correctly res = ast_play_and_wait(chan, "vm-nomessages"); current code sounds incorrect in portuguese for no messages vm-youhave vm-no vm-messages | ||
Comments: | By: Asterisk Team (asteriskteam) 2015-07-28 11:29:41.146-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Rusty Newton (rnewton) 2015-07-31 18:43:05.818-0500 We don't have anyone on the core team that speaks Portuguese to check this. Can you provide a patch and then push it through to review on Gerrit then perhaps we can find someone to review it? Thanks! https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Asterisk Team (asteriskteam) 2015-08-15 12:00:21.541-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Pedro (pedrodm) 2015-08-15 12:23:33.375-0500 Sorry about delay feedback. Been away on holidays. I am native pt_PT. Patch is simple. static int vm_intro_pt function should be the same as static int vm_intro_pt_BR This way pt_PT will play sounds correctly when there are no messages in the voice-mail By: Asterisk Team (asteriskteam) 2015-08-15 12:23:34.428-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. By: Rusty Newton (rnewton) 2015-08-17 18:14:59.371-0500 The patch may be simple but there is still work around getting it in. All patches must be submitted under the submission agreement. https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage Thanks! By: Asterisk Team (asteriskteam) 2015-10-01 12:00:21.338-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Pedro (pedrodm) 2015-12-01 06:29:30.080-0600 Correct vm_intro_pt function is the following. [Edit by Rusty - Removed your inline patch. As was already mentioned, we cannot accept inline patches or patches not submitted as a code contribution] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process |