Summary:	ASTERISK-25310: [patch]on FreeBSD also pthread_attr_init() defaults to PTHREAD_EXPLICIT_SCHED
Reporter:	Guido Falsi (madpilot)	Labels:
Date Opened:	2015-08-10 09:35:46	Date Closed:	2015-09-29 16:31:36
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:	11.19.0 13.5.0	Frequency of Occurrence
Related Issues:
Environment:	FreeBSD 9.3 and up	Attachments:	( 0) patch-main__utils.c
Description:	Hi, I'm currently maintaining the FreeBSD ports for asterisk. For versions 11.x and 13.x I'm using the attached patch to make it com pile and work on FreeBSD. I'd like this change to be imported by the asterisk project.
Comments:	By: Asterisk Team (asteriskteam) 2015-08-10 09:35:48.115-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Guido Falsi (madpilot) 2015-08-10 09:39:47.795-0500 The system isn't allowing me to upload a code patch. This is a trivial patch, and I don't think any signed document is really needed to contribute it. The patch is already released in the public and available in the FreeBSD ports tree: for asterisk 11: https://svnweb.freebsd.org/ports/head/net/asterisk11/files/patch-main__utils.c?revision=393727&view=co for asterisk 13: https://svnweb.freebsd.org/ports/head/net/asterisk13/files/patch-main__utils.c?revision=393727&view=co By: Rusty Newton (rnewton) 2015-08-10 19:07:51.054-0500 You must sign the submission agreement (contributors license agreement) to submit a patch, no matter how trivial. It is required in all cases. You can read about the [patch contribution process on the wiki|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Rusty Newton (rnewton) 2015-08-10 19:08:30.691-0500 Once your submission agreement is processed then you can re-attach your patch and it will show up (currently it does not display to others). By: Asterisk Team (asteriskteam) 2015-08-25 12:00:20.718-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Guido Falsi (madpilot) 2015-08-25 12:19:06.296-0500 Hi again, Sorry for the delay, I have finally signed the agreement and attached the patch file realtive to asterisk13. Patch for asterisk11 is the almost identical. Thanks in advance. By: Asterisk Team (asteriskteam) 2015-08-25 12:19:07.082-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. By: Rusty Newton (rnewton) 2015-08-26 15:48:08.004-0500 Guido, thanks!  The next step in the process is to put the patch through review on Gerrit and it can get merged from there. You'll need to walk it through the process. https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Guido Falsi (madpilot) 2015-08-31 11:27:56.783-0500 Hi, I'm trying to get a review ready on gerrit but I'm experiencing a problem. I've only rarely used git, so I'm not an expert on it. I did commit the change but used a line longer than 80 characters. git review refuses to work with such a commit, I tried --amend but cannot simply push that. What's the correct procedure to modify the commit message so that it's acceptable to the git review command? Thanks. By: Guido Falsi (madpilot) 2015-09-01 10:24:01.377-0500 Finally succeeded in getting this on gerrit: https://gerrit.asterisk.org/#/c/1171/ Do I need to file gerrit patches relative to branches 11 and 13 too? Thanks. By: Joshua C. Colp (jcolp) 2015-09-01 10:34:02.474-0500 Yes, and the patch you submitted doesn't seem to build. By: Guido Falsi (madpilot) 2015-09-01 11:00:04.450-0500 Sorry, I made a cut&paste error in that patch. Just uploaded a correct one, which seems to work better (build still running on jenkins)