[Home]

Summary:ASTERISK-25470: SDP version increased when no change in SDP on 183 session progress retransmit
Reporter:Morten Tryfoss (mtryfoss)Labels:
Date Opened:2015-10-16 15:55:30Date Closed:2020-01-14 11:13:55.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:13.5.0 13.6.0 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Centos 6Attachments:
Description:183 is retransmitted by Asterisk every 60 seconds. The version is bumped even if there are no change in the SDP.

Some equipment terminates the call because of this.

We had a similar error like this earlier, but then asterisk bumped the version on the 200 OK after a 183 session progress.

Reproduce like this:
{noformat}
progressinband=yes
{noformat}
{noformat}
exten => 200,1,Progress
exten => 200,n,Wait(65)
{noformat}
First SDP:
{noformat}
v=0
o=root 179570363 179570363 IN IP4 192.168.1.50
s=Nordicom
c=IN IP4 192.168.1.50
t=0 0
m=audio 12914 RTP/AVP 8 97
a=rtpmap:8 PCMA/8000
a=rtpmap:97 telephone-event/8000
a=fmtp:97 0-16
a=ptime:20
a=maxptime:150
a=sendrecv
{noformat}

Second:
{noformat}
v=0
o=root 179570363 179570364 IN IP4 192.168.1.50
s=Nordicom
c=IN IP4 192.168.1.50
t=0 0
m=audio 12914 RTP/AVP 8 97
a=rtpmap:8 PCMA/8000
a=rtpmap:97 telephone-event/8000
a=fmtp:97 0-16
a=ptime:20
a=maxptime:150
a=sendrecv
{noformat}
Comments:By: Asterisk Team (asteriskteam) 2015-10-16 15:55:31.720-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Morten Tryfoss (mtryfoss) 2015-10-16 16:06:27.561-0500

I think it will be safe to change this in function send_provisional_keepalive_full?
{noformat}
if (pvt->invitestate < INV_COMPLETED) {
if (with_sdp) {

- transmit_response_with_sdp(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq, XMIT_UNRELIABLE, FALSE, FALSE);
+ transmit_response_with_sdp(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq, XMIT_UNRELIABLE, TRUE, FALSE);
} else {
transmit_response(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq);
}
{noformat}
By: Rusty Newton (rnewton) 2015-10-16 16:21:27.104-0500

We require additional debug to continue with triage of your issue. Please follow the instructions on the wiki [1] for how to collect debugging information from Asterisk. For expediency, where possible, attach the debug with a '.txt' file extension so that the debug will be usable for further analysis.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Collecting+Debug+Information

Please include the output of "sip set debug on" inside your debug log.
By: Morten Tryfoss (mtryfoss) 2015-10-16 16:26:59.345-0500

The patch works for me, and changing the version without changing the SDP is clearly wrong.

What more debug can I provide than a way to reproduce it every time?
By: Rusty Newton (rnewton) 2015-10-21 09:28:35.156-0500

Many reporters attempt to provide information on how to reproduce an issue. Often, probably more often than not the information does not lead us to being able to reproduce the issue.

Often a debug log can provide us further detail about how Asterisk got into the problematic situation. It can help a developer understand the chain of events involved.

As simple as your suggested fix is - we can't accept inline patches due to licensing. You must submit a patch marked contribution after having signed the submission agreement.

Please submit the patch on here  and post it to Gerrit if you will - then others can review it and help verify the fix is appropriate. Thanks!

[Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]
By: Asterisk Team (asteriskteam) 2015-11-04 12:00:21.233-0600

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines