[Home]

Summary:ASTERISK-25499: G722 Codec and Inband DTMF Support
Reporter:balamurugan (balarth)Labels:
Date Opened:2015-10-27 22:14:30Date Closed:2020-01-14 11:13:41.000-0600
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:
Versions:12.1.1 13.3.0 Frequency of
Occurrence
Related
Issues:
Environment:Red Hat Enterprise Linux Server release 6.6 (Santiago)Attachments:
Description:There is no support for Detecting Inband DTMF on G722 Codec in dsp.c and we fail in collecting dtmf if the Endpoint Supports only Inband DTMF on G722 .
I have added code along the G722 Decoder in asterisk dsp.c to implement this and I can successfully collect the digits when it comes in inband . There are not many phones available supporting this and there is one specific phone which supports and tested this implementation using the same . Let me know if I can submit a patch to merge to mainstream.

thanks,
bala
Comments:By: Asterisk Team (asteriskteam) 2015-10-27 22:14:31.921-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Rusty Newton (rnewton) 2015-10-30 17:28:36.603-0500

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]
* As this is a new feature, please read the New Feature Guidelines [5]
* Make sure your new feature applies cleanly to Asterisk trunk

When ready, submit your patch and any tests to Gerrit [6] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines
[6] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

In short.. sign the submission agreement, attach the patch on JIRA and get the patch on Gerrit for review. You really want to at least check the patch against the coding guidelines as well.
By: balamurugan (balarth) 2015-11-02 09:32:10.541-0600

Sure Will attach the patch ASAP.
By: Rusty Newton (rnewton) 2015-11-04 18:53:30.662-0600

Thanks!
By: Asterisk Team (asteriskteam) 2015-11-19 12:00:22.562-0600

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines