| Summary: | ASTERISK-25583: [patch] format-attribute module: RFC 7587 (Opus Codec) | ||
| Reporter: | Alexander Traud (traud) | Labels: | |
| Date Opened: | 2015-11-21 05:21:22.000-0600 | Date Closed: | 2015-12-04 11:36:49.000-0600 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Resources/res_format_attr_opus |
| Versions: | 13.6.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) res_format_attr_opus.c ( 1) rfc7587.patch | |
| Description: | [RFC 7587|https://tools.ietf.org/html/rfc7587#section-6] for the Opus Codec was finalized in June 2015. Beside that, the current format-attribute module has the following issues:
* minptime should not be forwarded anymore (removed from RFC). * stereo is not parsed, if first parameter in fmtp. * {{get_joint}} should join all parameters. This allows to forward the bit-rate. For an internal transcoding module, this allows whether to use OPUS_SET_INBAND_FEC, OPUS_SET_DTX, and OPUS_APPLICATION_VOIP (!stereo). possible since ASTERISK-25545 * {{generate_sdp_fmtp}} does not work when used internally with a transcoding module: "if (!attr)" returns NULL instead of default. possible since ASTERISK-25160 * {{generate_sdp_fmtp}} should return only non-default parameters. This saves up to 149 bytes. For example, when many codecs are allowed in SDP, specifying all parameters might overrun the MTU bearer of 1300 bytes of SIP over UDP. * {{parse_sdp_fmtp}} should differentiate between the defaults of the RFC and best-practice for a B2BUA (= enable FEC). Therefore, the defaults of the RFC should be set in parse_sdp_fmtp explicitly. possible since ASTERISK-25537 | ||
| Comments: | |||