| Summary: | ASTERISK-25616: Warning with a Codec Module which supports PLC with FEC | ||
| Reporter: | Alexander Traud (traud) | Labels: | |
| Date Opened: | 2015-12-08 03:44:54.000-0600 | Date Closed: | 2015-12-08 13:16:49.000-0600 |
| Priority: | Trivial | Regression? | |
| Status: | Closed/Complete | Components: | Codecs/General |
| Versions: | 11.20.0 13.6.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) no_warning_on_fec.patch | |
| Description: | {{WARNING: translate.c:412 opustolin48 did not update samples 0}}
Some (audio) formats allow not just native PLC but FEC, for example the [Opus Codec|https://github.com/seanbright/asterisk-opus/issues/9]. If no data is available but FEC is enabled, the transcoding module has to wait for another RTP payload to decide whether to go for PLC or FEC. When the transcoding module waits, the above message is emitted. In that case, that message is wrong but cannot be disabled because it uses the log level WARNING. This source-code was introduced in April 2006 with [SVN-18541|http://svnview.digium.com/svn/asterisk?view=revision&revision=18541]. I searched a bit on the discussion board, mailing lists, and issue reports: The above message was never ever the only one being emitted. Furthermore, the transcoding module itself should emit a warning when it is not able to update the samples. Therefore, we have several choices for disabling this message: A) if module supports PLC and f(rame)->datalen == 0, B) change the level from WARNING to DEBUG-5, or C) remove that message completely. | ||
| Comments: | By: Alexander Traud (traud) 2015-12-08 03:47:08.141-0600 The attached patch removes that message completely (alternative C). | ||