| Summary: | ASTERISK-25693: cdr_pgsql: Refactoring | ||
| Reporter: | Dmitry Wagin (dmitry2004@yandex.ru) | Labels: | |
| Date Opened: | 2016-01-13 06:28:39.000-0600 | Date Closed: | |
| Priority: | Minor | Regression? | No |
| Status: | Open/New | Components: | CDR/cdr_pgsql |
| Versions: | 13.18.2 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) cdr_pgsql-13.18.2.diff | |
| Description: | Refactoring cdr_pgsql
* Code cleanup * Fix small memory leak * Fix start without DB | ||
| Comments: | By: Asterisk Team (asteriskteam) 2016-01-13 06:28:40.991-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Dmitry Wagin (dmitry2004@yandex.ru) 2016-01-13 06:29:15.185-0600 patch By: Dmitry Wagin (dmitry2004@yandex.ru) 2016-07-18 06:00:25.487-0500 Long time nothing happens ((( By: Joshua C. Colp (jcolp) 2016-07-18 06:46:59.283-0500 If you put the change up on Gerrit then it will be reviewed and included faster. Instructions for doing so are on the wiki[1]. By not doing this you are asking someone else to take it through the complete process and with limited resources this can take some time. [1] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Richard Mudgett (rmudgett) 2017-11-15 11:59:26.660-0600 A patch file is needed [1] at a minimum. Attaching a copy of the C file doesn't show what changes you made since it doesn't tell us what version of the C file you started with. If anyone else made changes to the file since you did they are likely to be overwritten. [1] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process By: Dmitry Wagin (dmitry2004@yandex.ru) 2017-11-16 02:27:59.221-0600 Patch for Asterisk-13.18.2 By: Dmitry Wagin (dmitry2004@yandex.ru) 2017-11-16 02:37:25.929-0600 Yes Richard it is a good practice, but my changes were quite large. Latest version of the fix includes changes made in git. | ||