| Summary: | ASTERISK-25810: say.c calls for sounds in the subdir "digits" that don't exist (in Core). SayUnixTime or other Say... apps will fail out when they call these sounds. | ||||||||
| Reporter: | Nicolas Riendeau (Marbled) | Labels: | |||||||
| Date Opened: | 2016-02-24 17:54:57.000-0600 | Date Closed: | 2017-07-26 14:19:09 | ||||||
| Priority: | Minor | Regression? | No | ||||||
| Status: | Closed/Complete | Components: | Applications/app_sayunixtime Sounds | ||||||
| Versions: | 11.21.2 13.7.2 | Frequency of Occurrence | Constant | ||||||
| Related Issues: |
| ||||||||
| Environment: | Attachments: | ||||||||
| Description: | Originally identified in ASTERISK-25760 in the context of French sounds, though this appears to affect all the sounds in general. This doesn't appear related to any recent change with the sound files.
h3. Say.c calls sounds that don't exist in the target location * say.c calls for "digits/second", "digits/seconds", "digits/minute" and "digits/minutes". h3. Core apps call sounds that only exist in the Extra set for some languages * The "second" and "minute" files only exist in Extra sounds (for the few sets that have Extra sounds of course), not in Core sounds. h3. A couple of the files do exist, but not in the target location * I grabbed the latest English sound files (v1.5) and other versions going way back (v1.4.10). In both cases the "seconds" and "minutes" files have been historically and still are stored in the root of the Core directory (not the digits subdir) h3. Problem consistent across language sets * I checked the French sounds the same way and they match the English sounds. At glance at other sounds appears to reveal the same situation. In the future we should probably get "second" and "minute" sounds in Core (digits subdir) for all the Core sounds and move "seconds" and "minutes" to the digits subdir. One concern is that deployed configurations are probably expecting these files to be where they currently are installed. 1. Should we change say.c to call them where they exist? Or, 2. Should we move them all to the digits subdir? * If we decide to add these files to core then we should request that all the sounds contributors record them. Again only three languages have the "second" and "minute" files. | ||||||||
| Comments: | By: Rusty Newton (rnewton) 2016-02-24 18:00:35.402-0600 from ASTERISK-25760 , [~Marbled] suggested: {quote} don't know if it would be possible to do that, my guess is it might not be for legacy reasons, but I would be tempted to suggest to either do: 1) two "second" file, one named "second-order" and "second-time" for the two possible ways this file could be used. In the case of French the existing "second" file would be renamed "second-order" and the "seconds" file would be copied to "second-time". 2) Keep the existing names but put them in different folders. The "second" file for the unit of time could be placed in a folder named "time" for example (and o'clock and other similar files moved there) and the "second" meaning "2nd" could be moved to the existing "digits" folder. {quote} By: Rusty Newton (rnewton) 2016-02-24 18:04:43.930-0600 Changing reporter to [~Marbled] By: Rusty Newton (rnewton) 2017-07-26 14:19:04.973-0500 This has been mostly fixed, or as much as it will be for now. We didn't want to alter the historical location of the 'seconds' and 'minutes' files so we left those where they were already. For language sets that already had 'second' and 'minute' files in Extra we moved them to Core and into the root directory. We altered say.c to call the files in the appropriate location. For French, in addition we copied 'seconds' to 'second-time'. I think that is all we can do at the moment. A few of the supported language contributors didn't respond in time for the release (for adding 'second' and 'minute' files to Core) so I will create a new issue to track those we still need. By: Rusty Newton (rnewton) 2017-07-26 14:19:34.593-0500 Sound fixes in Core prompts 1.6 and Extra prompts 1.5.1 | ||||||||