Summary:	ASTERISK-25817: chan_sip: Keep alive messages contain trailing null byte
Reporter:	hypherion (hypherion)	Labels:
Date Opened:	2016-02-26 12:29:11.000-0600	Date Closed:
Priority:	Minor	Regression?
Status:	Open/New	Components:	Channels/chan_sip/General
Versions:	13.7.2	Frequency of Occurrence	Constant
Related Issues:
Environment:	Fedora 20	Attachments:	( 0) keepalive_packet.png
Description:	When configured with the 'keepalive' option (keepalive = 30 in sip.conf), Asterisk sends periodic keep alive packets to peers. These packets as sent with content '\r\n\0' instead of 'r\n\r\n' as indicated by RFC5626 section 4.4.1. This has the potential to confuse clients and not be interpreted as 'ping' packets.
Comments:	By: Asterisk Team (asteriskteam) 2016-02-26 12:29:12.000-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: hypherion (hypherion) 2016-02-26 12:29:47.766-0600 See attached screenshot from Wireshark. By: Sean Bright (seanbright) 2017-12-13 07:39:51.485-0600 I've fixed the {{\0}} byte issue in https://gerrit.asterisk.org/#/c/7537/ The ping message itself is still just a {{\r\n}} so I am leaving this open for now.