[Home]

Summary:ASTERISK-25830: Revision 2451d4e breaks NAT
Reporter:Sean Bright (seanbright)Labels:
Date Opened:2016-03-02 12:08:42.000-0600Date Closed:2016-03-03 21:46:49.000-0600
Priority:BlockerRegression?Yes
Status:Closed/CompleteComponents:Resources/res_pjsip_nat
Versions:SVN Frequency of
Occurrence
Constant
Related
Issues:
Environment:Attachments:( 0) sanitized-transport-and-endpoint-configs.conf
Description:{noformat}
18:01 <@seanbright> gtjoseph: 2451d4e breaks NAT for me (found with 'git bisect')
18:02 <@seanbright> the Contact header is not being rewritten by res_pjsip_nat
18:03 <@seanbright> i believe one or more of the comparisons in res_pjsip_nat.c:find_transport_state_in_use() are incorrect
18:03 <@seanbright> simple setup - asterisk behind NAT, itsp on the public iternet
18:04 <@seanbright> Contact header contains private IP
18:04 < gtjoseph> endpoint rewrite_contact is yes?
18:04 <@seanbright> gtjoseph: it is not, no
18:04 <@seanbright> gtjoseph: even if it is, it doesn't change anything
18:05 <@seanbright> gtjoseph: i have the same setup with a pre-2451d4e (no rewrite_contact) and it works correctly
18:05 <@seanbright> i'm fairly certain that the pointer comparison on (current) line 161 is bogus
18:05 <@seanbright> details->transport == transport_state->transport
{noformat}
Comments:By: Asterisk Team (asteriskteam) 2016-03-02 12:08:42.885-0600

The severity of this issue has been automatically downgraded from "Blocker" to "Major". The "Blocker" severity is reserved for issues which have been determined to block the next release of Asterisk. This severity can only be set by privileged users. If this issue is deemed to block the next release it will be updated accordingly during the triage process.

By: Asterisk Team (asteriskteam) 2016-03-02 12:08:43.120-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

By: Sean Bright (seanbright) 2016-03-02 12:16:02.005-0600

sanitized transport and endpoint configs