Summary:	ASTERISK-26124: res_agi: Set audio format for EAGI audio stream
Reporter:	John Fawcett (johnfawcett)	Labels:
Date Opened:	2016-06-19 14:09:48	Date Closed:	2017-05-25 17:12:00
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_agi
Versions:	13.9.1	Frequency of Occurrence
Related Issues:	is duplicated by ASTERISK-16840 EAGI application should support wideband audio
Environment:	Centos 7	Attachments:
Description:	Suggested enhancement is to be able to set the audio format for the stream that can be accessed by EAGI scripts. Currently the stream is slin 8kHz. Not wanting to add another parameter to EAGI which will not be backwards compatible with existing configurations, and also considering that the configuration will not necessarily be a global setting, the attached patch allows to set the format prior to calling the EAGI script by setting the variable: EAGI_AUDIO_FORMAT, for example Set(EAGI_AUDIO_FORMAT=slin48) I cannot attach the patch due to not having signed a Digium License Agreement. See the link under the URL above for the patch. Unfortunately I cannot sign with the current wording: "If ... or you are an employee of an organization, the person signing this Agreement represents that he or she is expressly authorized to execute this Agreement on that organization's behalf." The above wording is flawed because it means that people who are employees (even if the job is unrelated) have to sign the agreement on behalf of their employers. My open source activity is not related to my employment and I am not authorized to sign on behalf of my employer. I have no issues to assign the patch to Digium, but as the agreement is worded I cannot sign it.
Comments:	By: Asterisk Team (asteriskteam) 2016-06-19 14:09:49.316-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Rusty Newton (rnewton) 2016-06-20 12:56:33.219-0500 I think that wording is fine as long as you don't put your employer's information on the form. If you fill out only your individual information then you are not submitting on behalf of an employer.  I'll run this by legal to be sure, as I am no lawyer. By: John Fawcett (johnfawcett) 2016-06-20 13:53:25.376-0500 Just to be clearer: The phrase deals with two separate cases: 1) If you are providing the Submission on behalf of an organization or 2) you are an employee of an organization So while 1) is clear to me 2) applies to people who do work unrelated to their submission. In both cases (so including case 2) the representation being made is: "that he or she is expressly authorized to execute this Agreement on that organization's behalf." That representation should be made only for case 1), people submitting on behalf of an organization. For people who are employees of an organization, that are not submitting on behalf of that organization, that representation is not appropriate. What is the reason for that "or you are an employee of an organization"? What does that add? I suspect whoever added that did it for a reason, maybe similar to clause 4 of the Google CLA https://cla.developers.google.com/about/google-individual. I can sign the Google clause (because it would be true in my case), but I cannot sign the Digium version because my employer does not give me permission to sign the agreement on its behalf. By: Rusty Newton (rnewton) 2016-06-21 16:53:39.826-0500 I talked with our counsel and she suggested we change the wording to "If you are providing the Submission on behalf of an organization of which you are not an employee or if you are providing on behalf of an organization of which you are an employee, the person signing this Agreement represents that he or she is expressly authorized to execute this Agreement on that organization's behalf. " That should work for people in your case, who are submitting on their own behalf. Let me know if it makes sense. By: John Fawcett (johnfawcett) 2016-06-21 17:00:32.510-0500 With that change I will be able to sign it. A simplified wording with the same meaning would be "If you are providing the Submission on behalf of an organization the person signing this Agreement represents that he or she is expressly authorized to execute this Agreement on that organization's behalf." But both would work. Thanks a lot for taking the time to look into it. By: Rusty Newton (rnewton) 2016-06-22 09:31:45.907-0500 Thanks. We'll get it updated as soon as possible so you can get your patch in. By: Joshua C. Colp (jcolp) 2016-07-14 05:12:37.421-0500 The updated license agreement has been deployed. Are you able to see it and sign? Cheers! By: John Fawcett (johnfawcett) 2016-07-14 22:04:39.909-0500 Thanks I have signed the updated license. By: Rusty Newton (rnewton) 2016-07-15 16:48:33.711-0500 Great. It'll probably be approved by Monday of next week. Then you can attach the patch and submit it to Gerrit. Thanks. By: Rusty Newton (rnewton) 2016-07-18 08:38:22.205-0500 Michelle let me know that she approved it. You should be good to go now for the next steps. By: Joshua C. Colp (jcolp) 2016-07-20 11:48:26.597-0500 I'm assigning this to you for upload of the patch. By: Asterisk Team (asteriskteam) 2016-08-03 12:00:01.008-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Joshua C. Colp (jcolp) 2016-08-03 12:06:34.332-0500 This should not have been closed, fixed. By: Friendly Automation (friendly-automation) 2017-05-25 17:12:01.459-0500 Change 5707 merged by George Joseph: res_agi: Allow configuration of audio format of EAGI pipe [https://gerrit.asterisk.org/5707|https://gerrit.asterisk.org/5707] By: Friendly Automation (friendly-automation) 2017-05-25 19:02:48.551-0500 Change 5706 merged by George Joseph: res_agi: Allow configuration of audio format of EAGI pipe [https://gerrit.asterisk.org/5706|https://gerrit.asterisk.org/5706] By: Friendly Automation (friendly-automation) 2017-05-25 19:03:27.222-0500 Change 5708 merged by George Joseph: res_agi: Allow configuration of audio format of EAGI pipe [https://gerrit.asterisk.org/5708|https://gerrit.asterisk.org/5708]