Summary:	ASTERISK-26205: clang: BlocksRuntime does not link on Fedora 23
Reporter:	Corey Farrell (coreyfarrell)	Labels:
Date Opened:	2016-07-17 21:02:34	Date Closed:	2018-10-16 08:06:46
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:	SVN 11.22.0-rc1 13.9.1	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 0001-RAII_VAR-Fix-configure-for-clang-on-Fedora-23.patch
Description:	Fedora 23 with clang / llvm installed, also libBlocksRuntime.a from https://github.com/mackyle/blocksruntime.  Configure Asterisk with: {{CC=clang ./configure --enable-dev-mode}} This fails because {{-lBlocksRuntime}} does not work correctly.  For some reason on Fedora 23 you must use {{-Wl,-lBlocksRuntime}}.  Although both options pass {{-lBlocksRuntime}} to the linker, the {{-Wl,}} variant adds the parameter last. I'll post a patch once I've had a chance to do some testing on the build result from clang.
Comments:	By: Asterisk Team (asteriskteam) 2016-07-17 21:02:35.751-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: George Joseph (gjoseph) 2016-07-18 07:29:27.760-0500 We had an IRC discussion about this and I confirmed the same issue on Fedora 24 and Ubuntu 16. By: Corey Farrell (coreyfarrell) 2016-07-18 18:02:19.306-0500 [~gjoseph]: I've attached the patch I came up with (it's against 13 HEAD).  Asterisk builds but doesn't run.  I tried running testsuite {{tests/manager/originate}}, it produced a bunch of runtime errors that seem to be added by clang.  This does not appear to be related to BlocksRuntime. In any case the patch does allow use of scan-build static analyzer from Fedora 23. By: Corey Farrell (coreyfarrell) 2018-10-16 08:06:46.313-0500 Fedora 28 provides libblocksruntime packages and the configure script correctly detects them, so this is no longer an issue.