| Summary: | ASTERISK-26211: Unit tests: AST_TEST_DEFINE should be used in conditional code. | ||
| Reporter: | Corey Farrell (coreyfarrell) | Labels: | |
| Date Opened: | 2016-07-18 18:34:48 | Date Closed: | 2016-07-20 10:59:56 |
| Priority: | Trivial | Regression? | |
| Status: | Closed/Complete | Components: | Applications/app_voicemail Channels/chan_sip/General Functions/func_curl Resources/res_pjsip Tests/General |
| Versions: | SVN 11.22.0-rc1 13.9.1 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | app_voicemail, chan_sip, func_curl and res_pjsip have tests where {{AST_TEST_DEFINE}} is not protected by an {{#ifdef TEST_FRAMEWORK}}. This causes dead-code to be included in the modules when TEST_FRAMEWORK is disabled. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2016-07-18 18:34:48.743-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. | ||