Summary: | ASTERISK-26288: followme: fails to reset config items to default values on reload | ||
Reporter: | Tzafrir Cohen (tzafrir) | Labels: | |
Date Opened: | 2016-08-11 11:46:15 | Date Closed: | 2016-08-22 16:38:32 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | Applications/app_followme |
Versions: | 13.10.0 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ( 0) 26288.diff | |
Description: | Scenario:
1. In followme.conf in section [test] set 'pls_hold_prompt' to the value 'whatever'. 2. Reload (asterisk -rx 'module reload app_followme.so') 3. Run 'FollowMe(test). The sound file 'whatever' should be prompted. 4. Edit followme.so and rem-out the line 'pls_hold_prompt' 5. Reload 6. Run FollowMe(test) * Expected result: The sound file 'followme/pls-hold-while-try' is played. * Actual result: The sound file 'whatever' is still played. Configuration to reproduce: {code} ; followme.conf [general] [test] pls_hold_prompt = whatever {code} {code} ; extensions.conf [test] exten => test,1,NoOp() same => n,Answer same => n,Echo same => n,Hangup {code} asterisk -rx 'channel originate Local/test@test application FollowMe test' | ||
Comments: | By: Asterisk Team (asteriskteam) 2016-08-11 11:46:15.775-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Tzafrir Cohen (tzafrir) 2016-08-11 11:48:20.802-0500 Add an initial patch vs. branch 13. Will post a review vs. master (I guess this patch applies as is) later. I'm not sure how to test this with the realtime code path. By: Tzafrir Cohen (tzafrir) 2016-08-11 12:16:11.027-0500 It seems that the fix for master needed slight changes indeed. See https://gerrit.asterisk.org/3484 . |