| Summary: | ASTERISK-26416: pjproject-bundled: configure fails to check for all required utilities | ||
| Reporter: | Corey Farrell (coreyfarrell) | Labels: | |
| Date Opened: | 2016-09-28 11:45:55 | Date Closed: | 2016-10-12 11:05:55 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Resources/res_pjsip/Bundling |
| Versions: | 13.11.2 14.0.1 GIT | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | This issue was found while working on a Centos 7 Dockerfile to run the testsuite. When I attempted to enable bundled pjproject first it failed due to 'lack of download program'. This was actually lack of 'which' utility. Additional utilities that are run by pjproject bundling Makefile:
* bzip2 (for tar extraction) * autoconf The main configure.ac should be determining if build requirements are available and fail when bundled pjproject is requested but impossible. For finding the download program we should use AC_PROG_PATH instead of which. We should check for / fail if otherwise unneeded utilities are missing (bzip2, autoconf). Additionally we should not be running utilities directly by name in third-party/pjproject/Makefile. For example instead of {{sed}} we should run {{$\{SED\}}}. Always use the results of ./configure! | ||
| Comments: | By: Asterisk Team (asteriskteam) 2016-09-28 11:45:56.293-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Corey Farrell (coreyfarrell) 2016-09-30 09:46:59.082-0500 Additional comment, pjproject tarball download should recognize/respect any {{--with-externals-cache=PATH}} option given to Asterisk ./configure. This is another thing I noticed during testing of my Dockerfile for Asterisk testsuite that pjproject was being downloaded every time. If you'd like I can open a separate ticket for this. By: George Joseph (gjoseph) 2016-09-30 10:50:30.681-0500 I'll do everything together | ||