Summary:	ASTERISK-26422: [patch] Force calendars to do new fetch after module reload
Reporter:	Ludovic Gasc (Eyepea) (gmludo)	Labels:
Date Opened:	2016-09-29 00:40:41	Date Closed:	2016-10-12 19:47:39
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_calendar/NewFeature
Versions:	13.9.1	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	Hi, We use a lot res_calendar, we are very happy with that, especially because you use libical, the almost alone opensource library that supports really ical format with all types of recurrency. Nevertheless, some features are missed for our business use cases. This first patch adds a new option in calendar.conf: fetch_again_at_reload Be my guest for a better name. If it's true, when you'll launch "module reload res_calendar.so", Asterisk will download again the calendar. The business use case is that we have a WebUI with a scheduler planner, we know when the calendars are modified. For now, we need to define 1 minute of timeout to have a chance that our user doesn't wait too long between the modification and the real test. But it generates a lot of useless HTTP traffic. I'm putting the very small patch in Gerrit. Have a nice Astricon.
Comments:	By: Asterisk Team (asteriskteam) 2016-09-29 00:40:42.187-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Martin Tomec (matesstar) 2016-12-28 10:49:03.536-0600 Hi, I have tested this patch with ical calendars, and after each "module reload res_calendar.so" I have more calendars loaded. Old calendars are probably not unloaded: {noformat} asttest*CLI> calendar show calendars Calendar             Type       Status --------             ----       ------ test2                ical       busy asttest*CLI> module reload res_calendar.so Module 'res_calendar.so' reloaded successfully. asttest*CLI> calendar show calendars Calendar             Type       Status --------             ----       ------ test2                ical       busy test2                ical       busy {noformat} By: Rusty Newton (rnewton) 2016-12-29 17:39:18.491-0600 [~matesstar], create a new issue report so that we can track fixing the side-effect or problem with the patch. It is easier to track that way than re-opening an already closed/fixed issue. Just note this issue in the new report and we can link the issues as "caused by". You can also tag the creator of the patch in the new issue using @.