[Home]

Summary:ASTERISK-26449: Add dockerfile to repo and official dockerhub repo
Reporter:Badalian Vyacheslav (slavon)Labels:
Date Opened:2016-10-09 10:06:28Date Closed:2020-01-14 11:13:46.000-0600
Priority:MajorRegression?
Status:Closed/CompleteComponents:
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Please add dockerfile to repo and regiser official repo in dockerhub.

Dockerhub can see pushes in github (https://github.com/asterisk/asterisk) and create autobuilds.

It's need to track changes and do fresh autobuilds in childrens dockerhub repos!

PS. Some time ago i was create asan autotest based on TestSute. Now i update versions....
https://hub.docker.com/r/slavon/docker-asterisk-testsute-asan/
Comments:By: Asterisk Team (asteriskteam) 2016-10-09 10:06:29.453-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Joshua C. Colp (jcolp) 2016-10-09 10:37:02.634-0500

As this is a feature request - do you plan on providing a Dockerfile which could be used for people for this use case?
By: Badalian Vyacheslav (slavon) 2016-10-09 10:42:35.893-0500

I will provide patch
By: Joshua C. Colp (jcolp) 2016-10-09 10:44:25.673-0500

I would suggest discussing before doing such a thing, as there are many people running Asterisk under Docker and trying to come up with something that everyone agrees would be useful would be best.
By: Badalian Vyacheslav (slavon) 2016-10-09 10:54:24.040-0500

My English is very bad. It will be difficult to discuss. You can take the matter to himself? I can help with the implementation if need be, and with commentary patch.
By: Joshua C. Colp (jcolp) 2016-10-09 10:59:10.647-0500

I'm really not familiar enough with Docker or have any knowledge in that area. Others have been doing that stuff.
By: Corey Farrell (coreyfarrell) 2016-10-09 14:27:49.813-0500

I'm not sure if I agree with publishing an official image to Docker hub.  An official Docker image would be based on a specific distribution.  As far as I know the Asterisk project doesn't have an opinion on which distribution is "best".

All testing I do and have ever done is on CentOS, so personally I'd choose CentOS as the base image.  Switching to Debian would mean that I'd be dealing with different versions and patch levels of Asterisk dependencies.  Others can say the reverse, if they've only ever tested under Debian they will prefer a Docker container based on Debian.  I don't think one-size fits all exists for Asterisk.

Maybe it would be better if we had a place on the Asterisk Wiki where community members could publish information about the packages they've published?  I say packages since this could like RPM sources like EPEL, DEB sources (sorry I don't know what they are), and Docker/Dockerfile sources.
By: Badalian Vyacheslav (slavon) 2016-10-09 18:19:47.846-0500

The problem is that DockerHub Triger works only with changes GitHub repository (and the repository should contain Dockerfile for assembly) or from another DockerHub repository.

Therefore, the possibility of only one. I made Dockerfile in your repository (prepare a patch), and you add DockerHub repository based on your mirror at GitHub. Then when you add changes to the GitHub will automatically be rebuilt image DockerHub and others can use this information in their DockerHub repositories, including as a Triger to rebuild a new version.

My repository ( https://hub.docker.com/r/slavon/docker-asterisk-testsute-asan/ )does the following:
1. Asterisk is compiled with the use of Asan.
2. Run your full TestSute.
3. Check all Address and Leak errors and arranges all the logs on the folder "/ (address | leak) / TEST_ID /"

With the new version, I immediately check it for errors ASAN before implementing it on featuring production systems.

I also use the CentOS;) but Docker lets you quickly in a container to collect the desired configuration of the versions. Virtual machines longer to install.

Also a big plus that Docker "out of the box" is integrated into many CI system.
By: Joshua C. Colp (jcolp) 2016-10-09 19:43:03.072-0500

What exactly would the purpose of the Dockerfile in Asterisk be? For people to use, or to run the testsuite in some manner?
By: Asterisk Team (asteriskteam) 2016-10-24 12:00:00.819-0500

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines